Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version_description to ec2_launch_template #1763

Merged
merged 8 commits into from
Apr 12, 2023
Merged

Add version_description to ec2_launch_template #1763

merged 8 commits into from
Apr 12, 2023

Conversation

squirrel532
Copy link
Contributor

SUMMARY

Add version_description to ec2_launch_template module, which allows user update the VersionDescription of a launch template.

Fix #1762

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_launch_template

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Mar 29, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d2843cb7c796485aad544d23182d66c3

❌ ansible-galaxy-importer FAILURE in 4m 19s
✔️ build-ansible-collection SUCCESS in 12m 38s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 02s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 26s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 07s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 28s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 30s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 47s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 33s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 59s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 06s
❌ ansible-test-changelog FAILURE in 4m 26s
✔️ ansible-test-splitter SUCCESS in 4m 50s
✔️ integration-community.aws-1 SUCCESS in 6m 57s
Skipped 21 jobs

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Apr 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/93613243853048f2922fdb8574348a3a

❌ ansible-galaxy-importer FAILURE in 4m 19s
✔️ build-ansible-collection SUCCESS in 13m 07s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 41s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 52s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 56s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 23s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 10s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 29s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 12s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 27s
✔️ ansible-test-changelog SUCCESS in 4m 25s
✔️ ansible-test-splitter SUCCESS in 4m 49s
✔️ integration-community.aws-1 SUCCESS in 6m 45s
Skipped 21 jobs

@squirrel532
Copy link
Contributor Author

@markuman I'm finished. Please review it.

@ansibullbot ansibullbot added integration tests/integration tests tests labels Apr 1, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/03a08c30de3040f9b87f8be892c5f26b

✔️ ansible-galaxy-importer SUCCESS in 3m 52s
✔️ build-ansible-collection SUCCESS in 13m 00s
✔️ ansible-test-sanity-docker-devel SUCCESS in 8m 44s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 42s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 34s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 52s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 20s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 15s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 32s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 45s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 46s
✔️ ansible-test-changelog SUCCESS in 4m 28s
✔️ ansible-test-splitter SUCCESS in 5m 30s
❌ integration-community.aws-1 FAILURE in 6m 26s
Skipped 21 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/559b50640fdc4e15a1a86398b344bd3d

❌ ansible-galaxy-importer FAILURE in 4m 14s
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 29s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 49s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 49s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 52s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 08s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 59s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 34s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 16s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 6m 17s
✔️ ansible-test-changelog SUCCESS in 4m 15s
✔️ ansible-test-splitter SUCCESS in 5m 00s
✔️ integration-community.aws-1 SUCCESS in 8m 18s
Skipped 21 jobs

@markuman markuman added the backport-5 PR should be backported to the stable-5 branch label Apr 3, 2023
@markuman markuman added this to the 5.5.0 milestone Apr 3, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c128b110ecd04b839b0ea51a13c9d1b7

❌ ansible-galaxy-importer FAILURE in 4m 38s
✔️ build-ansible-collection SUCCESS in 13m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 40s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 46s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 55s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 36s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 11m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 31s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 52s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 10s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 52s
✔️ ansible-test-changelog SUCCESS in 4m 49s
✔️ ansible-test-splitter SUCCESS in 5m 13s
✔️ integration-community.aws-1 SUCCESS in 6m 54s
Skipped 21 jobs

@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/241fad83c1874b3e9b307e70d064b652

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 12m 54s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 17s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 00s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 20s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 57s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 00s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 00s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 34s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 38s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 5m 48s
✔️ ansible-test-changelog SUCCESS in 4m 25s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-community.aws-1 SUCCESS in 6m 45s
Skipped 21 jobs

@markuman
Copy link
Member

markuman commented Apr 3, 2023

@squirrel532 we need some darker formations.
can you also apply them please? https://github.com/ansible-collections/community.aws/actions/runs/4594116048/jobs/8112755969?pr=1763

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a677e280c1814a88ba8e72733faadee0

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 12m 58s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 06s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 17s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 05s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 24s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 26s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 02s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 7m 47s
✔️ ansible-test-changelog SUCCESS in 4m 20s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-community.aws-1 SUCCESS in 6m 48s
Skipped 21 jobs

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Apr 12, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/d5de99e2630242999adcce6ac333bee2

✔️ ansible-galaxy-importer SUCCESS in 4m 23s
✔️ build-ansible-collection SUCCESS in 13m 27s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 23s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 15m 09s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 34s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 14m 58s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 15m 02s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 16s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 42s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 53s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 08s
✔️ ansible-test-changelog SUCCESS in 4m 32s
✔️ ansible-test-splitter SUCCESS in 4m 49s
✔️ integration-community.aws-1 SUCCESS in 8m 09s
Skipped 21 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3c3698d into ansible-collections:main Apr 12, 2023
@patchback
Copy link

patchback bot commented Apr 12, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/3c3698d79ce5f56cefd24efe98cc49e6330f4c29/pr-1763

Backported as #1770

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 12, 2023
@squirrel532 @patchback
Add version_description to ec2_launch_template (#1763)
1c0ae0b 
Add version_description to ec2_launch_template

SUMMARY
Add version_description to ec2_launch_template module, which allows user update the VersionDescription of a launch template.
Fix #1762

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_launch_template
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 3c3698d)
@patchback patchback bot mentioned this pull request Apr 12, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 12, 2023
@patchback
Add version_description to ec2_launch_template (#1763) (#1770)
63920a1 
[PR #1763/3c3698d7 backport][stable-5] Add version_description to ec2_launch_template

This is a backport of PR #1763 as merged into main (3c3698d).
SUMMARY
Add version_description to ec2_launch_template module, which allows user update the VersionDescription of a launch template.
Fix #1762


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
[7.0.0] Bump minimum botocore requirements (ansible-collections#1763)
869c6ee 
[7.0.0] Bump minimum botocore requirements

SUMMARY
In line with policy bump minimum botocore requirement to 1.29.0 (released Nov 2022) in preparation for release 7.0.0
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

@tremble tremble Awaiting requested review from tremble

@alinabuzachis alinabuzachis Awaiting requested review from alinabuzachis

Assignees
No one assigned
Labels
backport-5 PR should be backported to the stable-5 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Add version_description to ec2_launch_template
4 participants
@squirrel532 @ansibullbot @alinabuzachis @markuman