Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move module_utils out of subdir #23

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Move module_utils out of subdir #23

merged 1 commit into from
Jun 16, 2020

Conversation

flowerysong
Copy link
Contributor

SUMMARY

ansible-collections/amazon.aws#26

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

@flowerysong flowerysong mentioned this pull request Apr 6, 2020
Merged
@jillr jillr self-assigned this Apr 6, 2020
@jillr
Copy link
Collaborator

jillr commented Apr 14, 2020

We should be consistent between the aws collections with where we import camel_dict_to_snake_dict and snake_dict_to_camel_dict from, I've already asked s-hertel for the backstory on importing that from ec2.py in the other PR so let's sort that question out there first.

@flowerysong
Copy link
Contributor Author

@jillr I was less concerned about cleaning that up in this PR, since it's not (strictly speaking) part of the directory flattening and is a less intrusive change.

@flowerysong flowerysong force-pushed the flatten-module-utils branch 3 times, most recently from 3b73a3d to 4c728bd Compare June 15, 2020 15:20
@jillr
Copy link
Collaborator

jillr commented Jun 16, 2020

@flowerysong I modified the test requirements file on you, apologies. I'd like to get this merged this week if possible, let me know if you don't have time to work on it and would like me to fix it up.

@flowerysong flowerysong force-pushed the flatten-module-utils branch from 1948631 to dd39973 Compare June 16, 2020 21:02
@flowerysong flowerysong mentioned this pull request Jun 16, 2020
Merged
@flowerysong flowerysong changed the title [WIP] Move module_utils out of subdir Move module_utils out of subdir Jun 16, 2020
jillr
jillr approved these changes Jun 16, 2020
View reviewed changes
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@jillr jillr merged commit 10853d9 into ansible-collections:master Jun 16, 2020
@flowerysong flowerysong deleted the flatten-module-utils branch July 8, 2020 20:34
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 14, 2021
@flowerysong
[promoted]Update module_utils paths to remove aws subdir (ansible-col…
6060ce7 
…lections#23)

Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 15, 2021
@flowerysong
[promoted]Update module_utils paths to remove aws subdir (ansible-col…
0474815 
…lections#23)

Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@flowerysong
[promoted]Update module_utils paths to remove aws subdir (ansible-col…
5af3a86 
…lections#23)

Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 17, 2021
@flowerysong
[promoted]Update module_utils paths to remove aws subdir (ansible-col…
65b87e0 
…lections#23)

Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@4d63937
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@flowerysong
Update module_utils paths to remove aws subdir (ansible-collections#23)
805aba9 
Co-authored-by: Ezekiel Hendrickson <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@flowerysong
Update module_utils paths to remove aws subdir (ansible-collections#23)
8e01d14 
Co-authored-by: Ezekiel Hendrickson <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@flowerysong
Update module_utils paths to remove aws subdir (ansible-collections#23)
4d63937 
Co-authored-by: Ezekiel Hendrickson <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@jillr
Add build_ignore for test credentials to galaxy.yml (ansible-collecti…
8102847 
…ons#23)
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@flowerysong @jillr
Update module_utils paths to remove aws subdir (ansible-collections#23)
3ebea98 
Co-authored-by: Ezekiel Hendrickson <[email protected]>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@flowerysong @jillr
Update module_utils paths to remove aws subdir (ansible-collections#23)
2bc7ddd 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@flowerysong @jillr
Update module_utils paths to remove aws subdir (ansible-collections#23)
fdac86b 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
6f00a57 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @alinabuzachis
Update module_utils paths to remove aws subdir (ansible-collections#23)
5448321 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
dcf0052 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
e923c13 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
e36504b 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
9367421 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
25d2333 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
92365d0 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
f2cc00d 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @goneri
Update module_utils paths to remove aws subdir (ansible-collections#23)
2573040 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @alinabuzachis
Update module_utils paths to remove aws subdir (ansible-collections#23)
9b2886a 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @alinabuzachis
Update module_utils paths to remove aws subdir (ansible-collections#23)
5cf19b3 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @alinabuzachis
Update module_utils paths to remove aws subdir (ansible-collections#23)
6b47f3a 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @mandar242
Update module_utils paths to remove aws subdir (ansible-collections#23)
4800bf2 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @alinabuzachis
Update module_utils paths to remove aws subdir (ansible-collections#23)
9e10708 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@flowerysong @github-actions
Update module_utils paths to remove aws subdir (ansible-collections#23)
b067ee3 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@10853d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

Assignees

@jillr jillr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flowerysong @jillr