-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup - use is_boto3_error_(message|code) #268
Merged
tremble
merged 11 commits into
ansible-collections:main
from
tremble:cleanup/is_boto3_error
Feb 5, 2021
Merged
Cleanup - use is_boto3_error_(message|code) #268
tremble
merged 11 commits into
ansible-collections:main
from
tremble:cleanup/is_boto3_error
Feb 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
cleanup/is_boto3_error
branch
2 times, most recently
from
October 20, 2020 10:43
b46759e
to
3834e9f
Compare
tremble
force-pushed
the
cleanup/is_boto3_error
branch
from
November 14, 2020 09:52
3834e9f
to
57cb6f0
Compare
ansibullbot
added
affects_2.10
feature
This issue/PR relates to a feature request
module
module
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
needs_triage
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
labels
Nov 16, 2020
ansibullbot
added
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Jan 13, 2021
tremble
force-pushed
the
cleanup/is_boto3_error
branch
from
January 15, 2021 14:54
57cb6f0
to
7e186c6
Compare
tremble
force-pushed
the
cleanup/is_boto3_error
branch
from
January 27, 2021 10:15
7e186c6
to
5cf14de
Compare
ansibullbot
removed
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Jan 27, 2021
@tremble I think rebasing and resolving your merge conflict will be needed for the failing tests so I didn't actually rerun them for you today |
ansibullbot
added
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
and removed
needs_triage
labels
Feb 3, 2021
….module_utils.common.dict_transformations
tremble
force-pushed
the
cleanup/is_boto3_error
branch
from
February 3, 2021 22:35
e8892e5
to
41c7024
Compare
ansibullbot
removed
the
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
label
Feb 3, 2021
jillr
approved these changes
Feb 3, 2021
Shippable tests are passing and @jillr has approved. There are a number of AZP failures, the ones I've looked into are related to resource_prefix being much longer in AZP. I'm going to merge this and then attack the AZP issues separately. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 16, 2021
…tions#268) * Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
* Reorder imports * Make use of is_boto3_error_message * Mass-migration over to is_boto3_error_code * Remove unused imports * unused vars in exception * Improve consistency around catching BotoCoreError and ClientError * Remove unused imports * Remove unused 'PolicyError' from iam_policy_info * Avoid catching botocore.exceptions.ClientError when we only want some error codes * Import camel_dict_to_snake_dict/snake_dict_to_camel_dict from ansible.module_utils.common.dict_transformations This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@4cf52ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects_2.10
feature
This issue/PR relates to a feature request
module
module
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
owner_pr
PR created by owner/maintainer
plugins
plugin (any type)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Make heavier use of is_boto3_error_code and is_boto3_error_message. This reduces the chances of accidentally dropping exceptions on the floor and makes some of the code paths simpler to follow.
ISSUE TYPE
COMPONENT NAME
plugins/modules/aws_elasticbeanstalk_app.py
plugins/modules/aws_glue_connection.py
plugins/modules/aws_glue_job.py
plugins/modules/aws_kms_info.py
plugins/modules/aws_ssm_parameter_store.py
plugins/modules/aws_step_functions_state_machine_execution.py
plugins/modules/aws_waf_condition.py
plugins/modules/cloudfront_invalidation.py
plugins/modules/cloudwatchevent_rule.py
plugins/modules/data_pipeline.py
plugins/modules/ec2_asg.py
plugins/modules/ec2_asg_info.py
plugins/modules/ec2_instance.py
plugins/modules/ec2_placement_group.py
plugins/modules/ec2_transit_gateway_info.py
plugins/modules/ec2_vpc_egress_igw.py
plugins/modules/ec2_vpc_nacl_info.py
plugins/modules/ec2_vpc_route_table.py
plugins/modules/ecs_ecr.py
plugins/modules/ecs_service_info.py
plugins/modules/efs.py
plugins/modules/elasticache.py
plugins/modules/elasticache_info.py
plugins/modules/elasticache_snapshot.py
plugins/modules/elb_target_group.py
plugins/modules/execute_lambda.py
plugins/modules/iam_group.py
plugins/modules/iam_managed_policy.py
plugins/modules/iam_password_policy.py
plugins/modules/iam_policy_info.py
plugins/modules/iam_role.py
plugins/modules/iam_role_info.py
plugins/modules/iam_user.py
plugins/modules/lambda_alias.py
plugins/modules/lambda_facts.py
plugins/modules/lambda_info.py
plugins/modules/lambda_policy.py
plugins/modules/lightsail.py
plugins/modules/rds_instance.py
plugins/modules/rds_param_group.py
plugins/modules/s3_lifecycle.py
plugins/modules/sqs_queue.py
ADDITIONAL INFORMATION
I recommend reviewing the commits separately it's easier to follow what's changing.