-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lambda - Wait before updating #857
Lambda - Wait before updating #857
Conversation
Build failed.
|
Build succeeded.
|
recheck |
@anjo-swe at the moment there is a in progress move to a new CI server, so two sets of the same tests currently run. I think the one that failed was just an intermittent failure as it passed in 1 set of the run. the |
Build succeeded.
|
@marknet15 thanks for re-checking. Looks like the PR passes all tests and is ready for review at this point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and clean to me. You also need to add a changelog fragment.
@markuman added changelog fragment, let me know if anything else is needed |
Build failed.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
recheck |
Build succeeded.
|
@anjo-swe could you possible rebase the branch from upstream main ? The old CI is now disabled I think but to clear the failed check I think it needs a fresh commit to run against. |
c8f1c47
to
ae660e8
Compare
Build succeeded.
|
@marknet15 rebased and looks like the build succeeded |
@alinabuzachis @markuman the check gate is all green now that the old CI is disabled, so I think the PR is all good now |
regate |
Build succeeded (gate pipeline).
|
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #904 🤖 @patchback |
Lambda - Wait before updating SUMMARY Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/ Fixes #830 ISSUE TYPE Bugfix Pull Request COMPONENT NAME module: lambda ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit ab4bda2)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #905 🤖 @patchback |
Lambda - Wait before updating SUMMARY Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/ Fixes #830 ISSUE TYPE Bugfix Pull Request COMPONENT NAME module: lambda ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit ab4bda2)
Lambda - Wait before updating SUMMARY Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/ Fixes #830 ISSUE TYPE Bugfix Pull Request COMPONENT NAME module: lambda ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> (cherry picked from commit ab4bda2) Co-authored-by: Andreas Jonsson <[email protected]>
[PR #857/ab4bda24 backport][stable-2] Lambda - Wait before updating This is a backport of PR #857 as merged into main (ab4bda2). SUMMARY Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/ Fixes #830 ISSUE TYPE Bugfix Pull Request COMPONENT NAME module: lambda ADDITIONAL INFORMATION
tagging docs fragment - comment cleanup (C&P) SUMMARY When creating the docs fragment in ansible-collections#844 the comment above the fragments was left behind from the fragment I used as a base, tweak the comment. ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/doc_fragments/tags.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Lambda - Wait before updating SUMMARY Updated lambda module to wait for State = Active & LastUpdateStatus = Successful based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/ Fixes ansible-collections#830 ISSUE TYPE Bugfix Pull Request COMPONENT NAME module: lambda ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@ab4bda2
SUMMARY
Updated lambda module to wait for
State
=Active
&LastUpdateStatus
=Successful
based on https://aws.amazon.com/blogs/compute/coming-soon-expansion-of-aws-lambda-states-to-all-functions/Fixes #830
ISSUE TYPE
COMPONENT NAME
module: lambda
ADDITIONAL INFORMATION