[PR #893/44daa2de backport][stable-3] Refactor iam_managed_policy module and add integration tests #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Refactor iam_managed_policy module and add integration tests SUMMARY Refactor iam_managed_policy module to: Improve AWS retry backoff logic Add check_mode support Fix module exit on updates to policies when no changes are present Other changes: Add disabled integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_managed_policy ADDITIONAL INFORMATION Backoff logic only partially covered the module, and it didn't support check_mode or have any integration tests. Due to the nature of the IAM based modules the tests are intentionally disabled but have been run locally: ansible-test integration iam_managed_policy --allow-unsupported --docker PLAY RECAP ********************************************************************* testhost : ok=20 changed=6 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0 AWS ACTIONS: ['iam:CreatePolicy', 'iam:CreatePolicyVersion', 'iam:DeletePolicy', 'iam:DeletePolicyVersion', 'iam:GetPolicy', 'iam:GetPolicyVersion', 'iam:ListEntitiesForPolicy', 'iam:ListPolicies', 'iam:ListPolicyVersions', 'iam:SetDefaultPolicyVersion'] Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 44daa2d)
ansibullbot
added
bug
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/44daa2ded8dc9f1dab0f7a4643176fe668a2a89c/pr-893
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
Add deprecation note about Python 3.6 SUMMARY The AWS SDK for Python has now dropped support for Python 3.6 and announced that in future they're dropping support 6 months after PSF End Of Support for a version. Keeping with our 1-year-old Botocore/Boto3 requirements, this will result in us needing to drop support for Python 3.6 in about a year, when we would be scheduled to bump to botocore >= 1.27.0, as 1.27.0 requires Python 3.7. This means we're generally going to drop support for a version of Python around 18 months after PSF End Of Support. For the sake of transparency to our users, add a deprecation notice. ISSUE TYPE Docs Pull Request COMPONENT NAME README.md ADDITIONAL INFORMATION (community.aws PRs will follow after the amazon.aws PRs are approved) Reviewed-by: Felix Fontein <[email protected]> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #893 as merged into main (44daa2d).
SUMMARY
Refactor
iam_managed_policymodule to:Other changes:
ISSUE TYPE
COMPONENT NAME
iam_managed_policy
ADDITIONAL INFORMATION
Backoff logic only partially covered the module, and it didn't support check_mode or have any integration tests.
Due to the nature of the IAM based modules the tests are intentionally disabled but have been run locally: