elb_application_lb - treat empty security group as VPC default #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
jillr
approved these changes
Mar 8, 2022
marknet15
approved these changes
Mar 9, 2022
jatorcasso
added a commit
to jatorcasso/community.aws
that referenced
this pull request
Mar 28, 2022
…le-collections#971) elb_application_lb - treat empty security group as VPC default SUMMARY Fixes idempotency issue when security_groups = [] by treating [] as using the VPC's default security group (like it does on creation). Fixes ansible-collections#28 Used same logic as amazon.aws.ec2_vpc_route_table does for using default igw Added integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Jill R <None> Reviewed-by: Mark Woolley <[email protected]> (cherry picked from commit 20b726a)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
…c default sg (#1025) Backport: elb_application_lb - check_mode support, alb attributes, vpc default sg SUMMARY Backport #894 #963 #971 manually to resolve conflicts. ISSUE TYPE Feature Pull Request COMPONENT NAME elb_application_lb Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
1 task
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…collections#971) ec2_security_group: Set rules->group_name's datatype as raw Signed-off-by: GomathiselviS [email protected] SUMMARY rules-> group_name can accept values of type list and str. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_security_group.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
[]as using the VPC's default security group (like it does on creation).amazon.aws.ec2_vpc_route_tabledoes for using default igwISSUE TYPE
COMPONENT NAME
elb_application_lb