Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix plugin sanity #130

Merged
merged 2 commits into from
Oct 4, 2020
Merged

[WIP] Fix plugin sanity #130

merged 2 commits into from
Oct 4, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

According to ansible/ansible#71795, <plugin_type>: should be replaced by name: in the plugin docs. Also according to ansible/ansible#71798, callback_type should be renamed to type. Finally, imports should be below the docs (but before anything else), as will be reported by ansible/ansible#71734.

I marked this as [WIP] since it should wait until ansible/ansible#71734 is finalized.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

collection

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@4d8bb83). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage        ?   73.11%           
=======================================
  Files           ?        7           
  Lines           ?      688           
  Branches        ?       72           
=======================================
  Hits            ?      503           
  Misses          ?      170           
  Partials        ?       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8bb83...1b12614. Read the comment docs.

@rrey rrey merged commit dc5f02f into ansible-collections:main Oct 4, 2020
@felixfontein felixfontein deleted the fix-plugin-sanity branch October 4, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants