Handle divergences between MySQL and MariaDB

[Jorge-Rodriguez]

SUMMARY

This is an initial proposal on how to handle the growing divergences between MariaDB and MySQL while keeping the module codebase as clean as possible.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

mysql collection

ADDITIONAL INFORMATION

[Jorge-Rodriguez]

@Andersson007 @bmalynovytch @bmildren This is my initial (non-working) proposal on the matter above. I'm submitting this draft for your review and comments before tackling further changes and making it actually functional. Thanks in advance for your feedback.

[Andersson007]

@Jorge-Rodriguez looks interesting.
it's not related to this PR: If you write to me a test email to aaklychkov at mail dot ru, it would be really great. I won't bother you requesting reviews, etc. via it, it's just for discussing general things rarely. Thanks!

[bmalynovytch]

The approach looks good to me for now 👍

[Jorge-Rodriguez]

I think it makes more sense to leave this PR as is, just laying out the boilerplate work for future development.
The current conditional branches for MySQL/MariaDB are already transitioned, but I would refrain from doing any further development now.

[codecov]

Codecov Report

Merging #103 (23fedb7) into main (baea97d) will increase coverage by 0.38%.
The diff coverage is 90.41%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   75.75%   76.14%   +0.38%     
==========================================
  Files          12       19       +7     
  Lines        1712     1748      +36     
  Branches      438      434       -4     
==========================================
+ Hits         1297     1331      +34     
- Misses        269      270       +1     
- Partials      146      147       +1     

Impacted Files	Coverage Δ
tests/unit/plugins/modules/test_mysql_user.py	100.00% <ø> (ø)
plugins/modules/mysql_user.py	81.15% <54.54%> (+0.14%)	⬆️
...ugins/module_utils/implementations/mariadb/user.py	77.77% <77.77%> (ø)
...odule_utils/implementations/mariadb/replication.py	100.00% <100.00%> (ø)
.../module_utils/implementations/mysql/replication.py	100.00% <100.00%> (ø)
plugins/module_utils/implementations/mysql/user.py	100.00% <100.00%> (ø)
plugins/modules/mysql_replication.py	66.79% <100.00%> (-1.83%)	⬇️
...t/plugins/module_utils/test_mariadb_replication.py	100.00% <100.00%> (ø)
...s/module_utils/test_mariadb_user_implementation.py	100.00% <100.00%> (ø)
...nit/plugins/module_utils/test_mysql_replication.py	100.00% <100.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baea97d...23fedb7. Read the comment docs.

[Andersson007]

cc @bmalynovytch

[Andersson007]

LGTM

[Andersson007]

@Jorge-Rodriguez please resolve the conflict

[Andersson007]

@Jorge-Rodriguez after you resolve the conflict, i think we could merge it. I emailed Benjamin 3 days ago. The tests passed, so i think it won't break anything.

[bmalynovytch]

This looks really good, a part from the code duplication, but we can't do much about it 🙁

[bmalynovytch]

I emailed Benjamin 3 days ago. The tests passed, so i think it won't break anything.

I know I'm a bit slow these days, no need to point it out 😝 (just kidding)

[Andersson007]

I emailed Benjamin 3 days ago. The tests passed, so i think it won't break anything.

I know I'm a bit slow these days, no need to point it out (just kidding)

Okay:) Anyway I didn't imply "Shame on @bmalynovytch":))))
It's just "he's informed", so, as in my country people sometimes say for fun, "silence is a sign of agreement":)))

[Jorge-Rodriguez]

Rebased and fixed the conflict.
@Andersson007 do we need a documentation fragment for this?

[Andersson007]

@Jorge-Rodriguez ah, yes, we need (we don't need it for doc changes only), thanks for reminding:)

[Andersson007]

yeah, we must always remember about the fragments when going to merge someone's PR...

[Jorge-Rodriguez]

yeah, we must always remember about the fragments when going to merge someone's PR...

We should add that to the wiki. Do you have the link to the relevant documentation from the developer guide? I always have trouble finding the article about changelog fragments

[Andersson007]

@Jorge-Rodriguez https://docs.ansible.com/ansible/devel/community/development_process.html#creating-a-changelog-fragment

[Andersson007]

@Jorge-Rodriguez thanks for the refactoring!
@bmalynovytch thanks for reviewing!