Deprecate REQUIRESSL privilege

[Jorge-Rodriguez]

SUMMARY

Parse the priv string to effectively turn the REQUIRESSL privilege into an alias for the equivalent setup in the tls_requires option.
Introduce a deprecation notice for the REQUIRESSL privilege.

Fixes #89 #121

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

mysql_user

[codecov]

Codecov Report

Merging #132 (35d8af5) into main (ecd15c8) will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   76.61%   77.13%   +0.51%     
==========================================
  Files          20       20              
  Lines        1770     1784      +14     
  Branches      436      436              
==========================================
+ Hits         1356     1376      +20     
+ Misses        268      265       -3     
+ Partials      146      143       -3     

Impacted Files	Coverage Δ
plugins/modules/mysql_user.py	82.58% <100.00%> (+1.43%)	⬆️
tests/unit/plugins/modules/test_mysql_user.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd15c8...35d8af5. Read the comment docs.

[Andersson007]

ERROR: Found 4 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/mysql_user.py:975:40: E226: missing whitespace around arithmetic operator
ERROR: plugins/modules/mysql_user.py:978:40: E226: missing whitespace around arithmetic operator
ERROR: plugins/modules/mysql_user.py:978:61: E226: missing whitespace around arithmetic operator
ERROR: plugins/modules/mysql_user.py:978:128: E226: missing whitespace around arithmetic operator

maybe something else in CI

[Jorge-Rodriguez]

Codecov is killing my OCD 😄

[Jorge-Rodriguez]

Ok, I was happily assuming that I wrote flawless code, but the fact that the integration tests were green when I removed all references to REQUIRESSL and forgot to invoke the new function would suggest that we weren't testing (properly) for REQUIRESSL so let's not merge this until I have proper tests in place.

[Andersson007]

Ok, I was happily assuming that I wrote flawless code, but the fact that the integration tests were green when I removed all references to REQUIRESSL and forgot to invoke the new function would suggest that we weren't testing (properly) for REQUIRESSL so let's not merge this until I have proper tests in place.

Sure, let me know when it's ready for review

[Jorge-Rodriguez]

Ping @kkeane @Andersson007

[Andersson007]

@Jorge-Rodriguez should we review it now or better to wait until the CI is green?

[Jorge-Rodriguez]

@Andersson007 let's wait. I think I've spotted the issue with the failed CI and it's a systemic one on the module utils. I'm going to try to fix it and piggyback it on this PR

[Jorge-Rodriguez]

@Andersson007 ok, one changed my mind. This is ready for review.

I checked the issue and the fix is not as straightforward as I initially estimated and it warrants A PR of it's own.

I'm going to open a discussion about it based on this comment

[Andersson007]

@bmalynovytch your thoughts on this?

[bmalynovytch]

LGTM

[Jorge-Rodriguez]

I will change the tests to what @Andersson007 suggested and that should make integration green before merging.

[Andersson007]

@Jorge-Rodriguez so, we will wait for the tests changes mentioned, right?

[Jorge-Rodriguez]

@Jorge-Rodriguez so, we will wait for the tests changes mentioned, right?

@Andersson007 yes, I'll ping you again when it's ready.

[Jorge-Rodriguez]

Ping @Andersson007
Ready

[Andersson007]

LGTM
@Jorge-Rodriguez thanks for the great work!

[Andersson007]

So, we're ready to conduct our first major release soon. Maybe next week, say, on Monday:) will see