-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mysql_user: add "update_password: on_new_username" argument, "password_changed" result field #365
mysql_user: add "update_password: on_new_username" argument, "password_changed" result field #365
Conversation
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 78.10% 77.71% -0.39%
==========================================
Files 27 27
Lines 2279 2307 +28
Branches 552 556 +4
==========================================
+ Hits 1780 1793 +13
- Misses 340 354 +14
- Partials 159 160 +1
Continue to review full report at Codecov.
|
Hi @Andersson007, @rsicart, can you have a look at this? |
for other folks' information: the discussion is happening in the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, except minor documentation changes.
I didn't look at code covering though.
changelogs/fragments/365-mysql_user-add-on_new_username-and-password_changed.yml
Outdated
Show resolved
Hide resolved
changelogs/fragments/365-mysql_user-add-on_new_username-and-password_changed.yml
Outdated
Show resolved
Hide resolved
Rebase is needed |
…ssword_changed.yml Co-authored-by: Benjamin MALYNOVYTCH <[email protected]>
…ssword_changed.yml Co-authored-by: Benjamin MALYNOVYTCH <[email protected]>
rebased onto main |
changelogs/fragments/365-mysql_user-add-on_new_username-and-password_changed.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Klychkov <[email protected]>
…ssword_changed.yml Co-authored-by: Andrew Klychkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last thing
changelogs/fragments/365-mysql_user-add-on_new_username-and-password_changed.yml
Outdated
Show resolved
Hide resolved
…ssword_changed.yml Co-authored-by: Andrew Klychkov <[email protected]>
@betanummeric thanks for the contribution! |
@betanummeric have you seen my comment? Would be great to hear your thoughts:) |
SUMMARY
fixes #344
on_new_username
toupdate_password
argument of module mysql_user.password_changed
boolean to module mysql_user.ISSUE TYPE
COMPONENT NAME
module mysql_user
ADDITIONAL INFORMATION
When
update_password: on_new_username
is set, reuse the password (plugin and authentication_string) when creating a new user if some user with the same name already exist. If the existing users with the same name have varying passwords, the password from the arguments is used like withupdate_password: always
.The result field
password_changed
is true, when the user got a new password. When the user was created withupdate_password: on_new_username
and an existing password was reused,password_changed
is false.