Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_db: add chdir argument #396

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Fixes #395

Add the chdir argument to avoid failings when a dump file contains relative paths

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mysql_db

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #396 (a0fe572) into main (2a3f8f6) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   77.71%   77.69%   -0.03%     
==========================================
  Files          27       27              
  Lines        2307     2313       +6     
  Branches      556      557       +1     
==========================================
+ Hits         1793     1797       +4     
- Misses        354      356       +2     
  Partials      160      160              
Impacted Files Coverage Δ
plugins/modules/mysql_db.py 74.40% <66.66%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3f8f6...a0fe572. Read the comment docs.

@Andersson007
Copy link
Collaborator Author

ready_for_review

@rsicart
Copy link
Contributor

rsicart commented Jun 10, 2022

LGTM 👍

@Andersson007 Andersson007 merged commit 8e79690 into ansible-collections:main Jun 13, 2022
@Andersson007
Copy link
Collaborator Author

@rsicart thanks much for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

community.mysql.mysql_db appears not to support relative paths when importing databases
2 participants