Allow uppercase in variable names for Galera wsrep variables #501
Conversation
There was a problem hiding this comment.
@pcampbell-payroc hello, thanks for the PR!
- Could you please add a changelog fragment (under
bugfixi think) so that our users will see the change? - We have an official room on Matrix to share experience, welcome to join!
|
I hope that's in the correct format for the project. |
| bugfix: | ||
| - mysql_variables - Add uppercase character pattern to regex to allow GLOBAL | ||
| variables containing uppercase characters. | ||
| This recognises variable names used in Galera, e.g. wsrep_OSU_method, | ||
| which break the normal pattern of all lowercase characters. |
There was a problem hiding this comment.
| bugfix: | |
| - mysql_variables - Add uppercase character pattern to regex to allow GLOBAL | |
| variables containing uppercase characters. | |
| This recognises variable names used in Galera, e.g. wsrep_OSU_method, | |
| which break the normal pattern of all lowercase characters. | |
| bugfixes: | |
| - mysql_variables - add uppercase character pattern to regex to allow GLOBAL | |
| variables containing uppercase characters. | |
| This recognizes variable names used in Galera, for example, ``wsrep_OSU_method``, | |
| which breaks the normal pattern of all lowercase characters (https://github.com/ansible-collections/community.mysql/pull/501). |
There was a problem hiding this comment.
sorry i made a mistake in the key
bugfix -> bugfixes (this will fix the sanity errors)
Also fyi: I'll be on Fosdem and if nobody merges it before I'll merge this at the end of next week
There was a problem hiding this comment.
Please make any changes you think are suitable. I only started working with Ansible last week so I'm really happy you were even considering accepting the change.
|
@pcampbell-payroc
You're a quintessence of contributor! :) It's so cool to see people giving back so fast! |
|
@pcampbell-payroc thank you for the contribution! |
SUMMARY
Galera wsrep global variables sometimes use uppercase identifiers (e.g.
wsrep_OSU_method) which causes them to fail validation against the existing regex. While it is possible to refer to these vars with their lowercase equivalents to make them work, this would be more confusing than changing the regex to support legal characters.