-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user.py #676
Update user.py #676
Conversation
Added correct syntax to ed25519 password plugin. on create user on update user This only accepts cleartext passwords (PASSWORD(%s)) not pregenerated ed25519 hashes.
removed my comment, slept bad. |
@hubiongithub please click |
Co-authored-by: Andrew Klychkov <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 76.31% 72.65% -3.67%
==========================================
Files 20 17 -3
Lines 2651 2607 -44
Branches 676 672 -4
==========================================
- Hits 2023 1894 -129
- Misses 427 487 +60
- Partials 201 226 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@hubiongithub have you tried to change the code same way locally and tested it and everything works as expected? Can i merge it and release 10.3.3? |
@Andersson007 despite the in ('pam') -> == 'pam' change I tested that locally and the user was created and the password worked. |
@hubiongithub thanks for the contribution! |
pasting the announcement i've just made: The community.mysql collection version 3.10.3 has been released! |
ansible-galaxy install -- force and retested, user gets created. Thank you |
@hubiongithub sure, thanks for the contribution! |
Added correct syntax to ed25519 password plugin.
on create user
on update user
This only accepts cleartext passwords (PASSWORD(%s)) not pregenerated ed25519 hashes.
SUMMARY
MariaDB uses ed25519 for stronger password hashes, the plugin needs the PASSWORD(%s) call if cleartext password is given in plugin_auth_string.
Hopefully fixes #672
ISSUE TYPE
COMPONENT NAME
mysql_user
ADDITIONAL INFORMATION
MariaDB accepts either a clear text password in ... USING PASSWORD('password') or a pregenerated hash in ... USING 'hash'
my changes only accept a cleartext password in "plugin_auth_string", so a generated hash will taken as the cleartext password and used in the PASSWORD(%s) call.