Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OceanBase support for creating user and setting password #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davidzhangbj
Copy link

SUMMARY

Oceanbase is compatible with most of the MySQL syntax, but there are a few that are not. In order to make community.mysql able to create users and set passwords in OceanBase, the incompatible parts of OceanBase have been specially handled.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Involves creating users and changing passwords

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.08%. Comparing base (022ed60) to head (3825d09).

Files with missing lines Patch % Lines
plugins/module_utils/user.py 25.00% 3 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (022ed60) and HEAD (3825d09). Click for more details.

HEAD has 132 uploads less than BASE
Flag BASE (022ed60) HEAD (3825d09)
units 27 0
sanity 12 0
integration 111 18
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   79.54%   74.08%   -5.47%     
==========================================
  Files          32       17      -15     
  Lines        2811     2620     -191     
  Branches      701      671      -30     
==========================================
- Hits         2236     1941     -295     
- Misses        395      463      +68     
- Partials      180      216      +36     
Flag Coverage Δ
integration 73.93% <45.45%> (-2.62%) ⬇️
sanity ?
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andersson007
Copy link
Collaborator

@davidzhangbj hello, thanks for the PR

However, this collections supports only MySQL and MariaDB and I'm not in favor of adding anything else because:

  • This collection focuses on MySQL and MariaDB because of legacy reasons. There were talks about splitting it into two collections to support them separately. Nobody wanted to take the maintenance burden but this should be split IMO.
  • It's getting harder and harder to maintain things like the code and CI even with respect to differences between MySQL and MariaDB. So it's again about splitting rather than adding new differences to handle.
  • It's open source: you could fork the collection, add support your like and publish it on Galaxy same as we do with this collection.
  • We welcome contributions to the current stuff and promote people to maintainers.

@laurent-indermuehle and others, what do you folks think?

@davidzhangbj
Copy link
Author

davidzhangbj commented Dec 24, 2024

@Andersson007 Hi, thank you very much for your reply. I will consider your suggestion.

@laurent-indermuehle
Copy link
Collaborator

I'm also not in favor for adding a new supported engine for the same reasons @Andersson007 listed.

But the request from @davidzhangbj is still understandable. At the same time I'm wondering if this is the only difference the collection needs to tackle in order to work for OceanBase?

@davidzhangbj If you wish to go for a fork, we could discuss how to organize the collection as an upstream. Maybe we could fork for MariaDB too... and upstream would become a place for the common methods + the MySQL specifics.

@davidzhangbj
Copy link
Author

@laurent-indermuehle I would like to go for a fork and create a community.oceanbase repository. Would this be feasible? Could you please provide guidance on the necessary steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants