-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OceanBase support for creating user and setting password #694
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
- Coverage 79.54% 74.08% -5.47%
==========================================
Files 32 17 -15
Lines 2811 2620 -191
Branches 701 671 -30
==========================================
- Hits 2236 1941 -295
- Misses 395 463 +68
- Partials 180 216 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@davidzhangbj hello, thanks for the PR However, this collections supports only MySQL and MariaDB and I'm not in favor of adding anything else because:
@laurent-indermuehle and others, what do you folks think? |
@Andersson007 Hi, thank you very much for your reply. I will consider your suggestion. |
I'm also not in favor for adding a new supported engine for the same reasons @Andersson007 listed. But the request from @davidzhangbj is still understandable. At the same time I'm wondering if this is the only difference the collection needs to tackle in order to work for OceanBase? @davidzhangbj If you wish to go for a fork, we could discuss how to organize the collection as an upstream. Maybe we could fork for MariaDB too... and upstream would become a place for the common methods + the MySQL specifics. |
@laurent-indermuehle I would like to go for a fork and create a community.oceanbase repository. Would this be feasible? Could you please provide guidance on the necessary steps? |
SUMMARY
Oceanbase is compatible with most of the MySQL syntax, but there are a few that are not. In order to make community.mysql able to create users and set passwords in OceanBase, the incompatible parts of OceanBase have been specially handled.
ISSUE TYPE
COMPONENT NAME
Involves creating users and changing passwords