-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add options to start and stop group replication #93
Draft: Add options to start and stop group replication #93
Conversation
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
==========================================
- Coverage 75.07% 73.58% -1.49%
==========================================
Files 12 12
Lines 1645 1681 +36
Branches 423 431 +8
==========================================
+ Hits 1235 1237 +2
- Misses 267 301 +34
Partials 143 143
Continue to review full report at Codecov.
|
@eryx12o45 hi, thanks for the PR. It's a draft but anyway, please
Thanks! |
@Andersson007 thanks for the comments. I've added a changelog fragment and renamed the commands. Unfortunately I will not be able to provide tests in the near future, because of time constraints and the fact, that I would need to extend the setup routine to add group replication configs, etc. otherwise the commands would never work :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eryx12o45 thanks for fixing! I'll take a deeper look when time allows
@@ -0,0 +1,2 @@ | |||
minor_changes: | |||
- mysql_replication - added options to `start_group_replication` and `stop_group_replication` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- mysql_replication - added options to `start_group_replication` and `stop_group_replication` | |
- mysql_replication - add ``start_group_replication`` and ``stop_group_replication`` options (https://github.com/ansible-collections/community.mysql/pull/93). |
@betanummeric @laurent-indermuehle @bmalynovytch @rsicart @Jorge-Rodriguez what do you think about these changes? Can we merge it w/o tests? (provided that the fragment is fixed) |
This PR needs rebase. I would wait for #63 to be merged and then rework these changes on top of it. Then we could add tests as well. |
@eryx12o45 could you please rebase the PR? if you have no time, let us know |
New version here --> #647 |
SUMMARY
ISSUE TYPE
COMPONENT NAME
mysql_replication moodule
ADDITIONAL INFORMATION