Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add options to start and stop group replication #93

Closed
wants to merge 2 commits into from
Closed

Draft: Add options to start and stop group replication #93

wants to merge 2 commits into from

Conversation

eryx12o45
Copy link

SUMMARY
  • Added options to start and stop group replication
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

mysql_replication moodule

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #93 (0883f8a) into main (31bd2b5) will decrease coverage by 1.48%.
The diff coverage is 8.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   75.07%   73.58%   -1.49%     
==========================================
  Files          12       12              
  Lines        1645     1681      +36     
  Branches      423      431       +8     
==========================================
+ Hits         1235     1237       +2     
- Misses        267      301      +34     
  Partials      143      143              
Impacted Files Coverage Δ
plugins/modules/mysql_replication.py 62.37% <8.10%> (-7.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31bd2b5...0883f8a. Read the comment docs.

@Andersson007
Copy link
Collaborator

@eryx12o45 hi, thanks for the PR. It's a draft but anyway, please

  1. add a changelog fragment
  2. add tests to make CI green
  3. maybe it's worth adding underscores to the new values to make them more human friendly?

Thanks!

@eryx12o45
Copy link
Author

@Andersson007 thanks for the comments. I've added a changelog fragment and renamed the commands. Unfortunately I will not be able to provide tests in the near future, because of time constraints and the fact, that I would need to extend the setup routine to add group replication configs, etc. otherwise the commands would never work :-(

Copy link
Collaborator

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eryx12o45 thanks for fixing! I'll take a deeper look when time allows

@@ -0,0 +1,2 @@
minor_changes:
- mysql_replication - added options to `start_group_replication` and `stop_group_replication`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- mysql_replication - added options to `start_group_replication` and `stop_group_replication`
- mysql_replication - add ``start_group_replication`` and ``stop_group_replication`` options (https://github.com/ansible-collections/community.mysql/pull/93).

@Andersson007
Copy link
Collaborator

@betanummeric @laurent-indermuehle @bmalynovytch @rsicart @Jorge-Rodriguez what do you think about these changes? Can we merge it w/o tests? (provided that the fragment is fixed)

@Jorge-Rodriguez
Copy link
Contributor

This PR needs rebase. I would wait for #63 to be merged and then rework these changes on top of it. Then we could add tests as well.

@Andersson007
Copy link
Collaborator

@eryx12o45 could you please rebase the PR? if you have no time, let us know

@eryx12o45
Copy link
Author

New version here --> #647

@eryx12o45 eryx12o45 closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants