Update routeros_facts #101

adeptvin1 · 2020-08-14T09:17:47Z

SUMMARY

I added variables to the "Default" function
ansible_net_architec:
ansible_net_uptime:
ansible_net_cpu_load:
And added the "Routing" function to collect data about BGP and OSPF.

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

routeros_facts.py

ADDITIONAL INFORMATION

felixfontein

You need a changelog fragment.

plugins/modules/network/routeros/routeros_facts.py

felixfontein · 2020-08-14T10:05:16Z

CC @heuels

heuels

Thanks for submitting a pull request! I've noted a few things that need correcting, but otherwise it's very good, thanks.

You'd also need to add unit tests and a changelog fragment.

plugins/modules/network/routeros/routeros_facts.py

Co-authored-by: Egor Zaitsev <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>

adeptvin1 · 2020-08-15T13:46:23Z

Hello, I created changelog fragment according to the instructions, I hope that it turned out correctly.. Also, can you tell us in what format you need to attach the unit test? Can there be instructions for me to prepare it correctly? I don't have much idea about it yet.

heuels · 2020-08-15T14:12:34Z

There already is a unit test file for routeros_facts module, you should add your tests there. See this file for reference: https://github.com/ansible-collections/community.network/blob/main/tests/unit/plugins/modules/network/routeros/test_routeros_facts.py.

changelogs/fragments/101_update_routeros_facts.yml

plugins/modules/network/routeros/routeros_facts.py

felixfontein · 2020-08-15T18:29:18Z

Also please check the sanity errors reported by CI (https://app.shippable.com/github/ansible-collections/community.network/runs/452/1/tests, https://app.shippable.com/github/ansible-collections/community.network/runs/452/2/tests, https://app.shippable.com/github/ansible-collections/community.network/runs/452/3/tests).

Co-authored-by: Felix Fontein <[email protected]>

felixfontein · 2020-08-18T04:55:14Z

Please check the failing sanity tests: https://app.shippable.com/github/ansible-collections/community.network/runs/463/1/tests https://app.shippable.com/github/ansible-collections/community.network/runs/463/2/tests https://app.shippable.com/github/ansible-collections/community.network/runs/463/3/tests

felixfontein · 2020-08-18T04:56:51Z

plugins/modules/network/routeros/routeros_facts.py

@@ -110,6 +123,34 @@
  description: The list of neighbors from the remote device
  returned: when interfaces is configured
  type: dict
+
+ # routing
+ ansible_net_bgp_peer:


This is indented wrongly. There is a leading space which shouldn't be there. (That makes it invalid YAML.)

I corrected it.

plugins/modules/network/routeros/routeros_facts.py

adeptvin1 · 2020-08-20T15:19:47Z

While we are still doing this work I would like to thank you for your help, you are very cool guys. I hope that in time I will learn to be like you, thank you very much.

adeptvin1 · 2020-08-20T16:14:35Z

CI verification was successful! Unexpectedly for me, this required a lot of corrections, I am ready for the next step.

felixfontein · 2020-08-20T18:14:34Z

recheck

felixfontein

LGTM. Also tested it with a real device, looks good!

@heuels if you want to check again feel free, otherwise let's merge this!

heuels

LGTM.

@adeptvin1, thank you so much for submitting this pull request!

felixfontein · 2020-08-21T11:04:28Z

@adeptvin1 thanks a lot for contributing this!
@heuels thanks a lot for reviewing!

* Update routeros_facts.py * Update routeros_facts.py * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Create 101_update_routeros_facts.yml * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/101_update_routeros_facts.yml Co-authored-by: Felix Fontein <[email protected]> * add test default function * add test data * Update routing_ospf_neighbor_print_detail_without-paging * add test function "Routing" * added information of version * Removed extra spaces * add one more version, "ansible_net_cpu_load" * remove many blank lines * remove 'too many blank lines' * renamed arhitec to arch * Update routeros_facts.py * Update test_routeros_facts.py * Update test_routeros_facts.py * one more * remove one route * Update test_routeros_facts.py * remove one neighbor Co-authored-by: Egor Zaitsev <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 6fa7295)

* Update routeros_facts.py * Update routeros_facts.py * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Egor Zaitsev <[email protected]> * Create 101_update_routeros_facts.yml * Update plugins/modules/network/routeros/routeros_facts.py Co-authored-by: Felix Fontein <[email protected]> * Update changelogs/fragments/101_update_routeros_facts.yml Co-authored-by: Felix Fontein <[email protected]> * add test default function * add test data * Update routing_ospf_neighbor_print_detail_without-paging * add test function "Routing" * added information of version * Removed extra spaces * add one more version, "ansible_net_cpu_load" * remove many blank lines * remove 'too many blank lines' * renamed arhitec to arch * Update routeros_facts.py * Update test_routeros_facts.py * Update test_routeros_facts.py * one more * remove one route * Update test_routeros_facts.py * remove one neighbor Co-authored-by: Egor Zaitsev <[email protected]> Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit 6fa7295) Co-authored-by: adeptvin1 <[email protected]>

adeptvin1 added 2 commits August 14, 2020 11:56

Update routeros_facts.py

e186983

Update routeros_facts.py

da8dca6

felixfontein reviewed Aug 14, 2020

View reviewed changes

plugins/modules/network/routeros/routeros_facts.py Show resolved Hide resolved

heuels reviewed Aug 14, 2020

View reviewed changes

adeptvin1 and others added 12 commits August 15, 2020 23:17

Update plugins/modules/network/routeros/routeros_facts.py

18bb90b

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

60cf2f6

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

03d05d1

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

f60b518

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

9fe9561

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

db26399

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

c304316

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

8a55bac

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

93d331c

Co-authored-by: Egor Zaitsev <[email protected]>

Update plugins/modules/network/routeros/routeros_facts.py

74cbc76

Co-authored-by: Egor Zaitsev <[email protected]>

Create 101_update_routeros_facts.yml

10dcee3

Update plugins/modules/network/routeros/routeros_facts.py

b9fd967

Co-authored-by: Felix Fontein <[email protected]>

felixfontein reviewed Aug 15, 2020

View reviewed changes

changelogs/fragments/101_update_routeros_facts.yml Outdated Show resolved Hide resolved

plugins/modules/network/routeros/routeros_facts.py Show resolved Hide resolved

Update changelogs/fragments/101_update_routeros_facts.yml

0e7b46c

Co-authored-by: Felix Fontein <[email protected]>

felixfontein reviewed Aug 18, 2020

View reviewed changes

adeptvin1 added 5 commits August 20, 2020 16:50

add test default function

ee1f714

add test data

119375c

Update routing_ospf_neighbor_print_detail_without-paging

50fbd8d

add test function "Routing"

8b807c2

added information of version

daa78ab

felixfontein reviewed Aug 20, 2020

View reviewed changes

plugins/modules/network/routeros/routeros_facts.py Show resolved Hide resolved

adeptvin1 added 2 commits August 20, 2020 18:14

Removed extra spaces

0e21f70

add one more version, "ansible_net_cpu_load"

dbec1f3

adeptvin1 added 10 commits August 20, 2020 18:28

remove many blank lines

c8da8c2

remove 'too many blank lines'

4e51019

renamed arhitec to arch

5e1baa1

Update routeros_facts.py

7c0395f

Update test_routeros_facts.py

5925e00

Update test_routeros_facts.py

7f77097

one more

7495f87

remove one route

b87cf2a

Update test_routeros_facts.py

121bbf2

remove one neighbor

8a8e408

felixfontein approved these changes Aug 20, 2020

View reviewed changes

heuels approved these changes Aug 21, 2020

View reviewed changes

felixfontein merged commit 6fa7295 into ansible-collections:main Aug 21, 2020

felixfontein added the needs_backport_to_stable_1 PR needs to be backported to the stable-1 branch label Aug 21, 2020

felixfontein added backport-stable-1 and removed needs_backport_to_stable_1 PR needs to be backported to the stable-1 branch labels Sep 17, 2020

patchback bot mentioned this pull request Sep 17, 2020

[PR #101/6fa72957 backport][stable-1] Update routeros_facts #113

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update routeros_facts #101

Update routeros_facts #101

adeptvin1 commented Aug 14, 2020

felixfontein left a comment

felixfontein commented Aug 14, 2020

heuels left a comment

adeptvin1 commented Aug 15, 2020

heuels commented Aug 15, 2020

felixfontein commented Aug 15, 2020

felixfontein commented Aug 18, 2020

felixfontein Aug 18, 2020

adeptvin1 Aug 20, 2020

adeptvin1 commented Aug 20, 2020

adeptvin1 commented Aug 20, 2020

felixfontein commented Aug 20, 2020

felixfontein left a comment

heuels left a comment

felixfontein commented Aug 21, 2020

Update routeros_facts #101

Update routeros_facts #101

Conversation

adeptvin1 commented Aug 14, 2020

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

felixfontein left a comment

Choose a reason for hiding this comment

felixfontein commented Aug 14, 2020

heuels left a comment

Choose a reason for hiding this comment

adeptvin1 commented Aug 15, 2020

heuels commented Aug 15, 2020

felixfontein commented Aug 15, 2020

felixfontein commented Aug 18, 2020

felixfontein Aug 18, 2020

Choose a reason for hiding this comment

adeptvin1 Aug 20, 2020

Choose a reason for hiding this comment

adeptvin1 commented Aug 20, 2020

adeptvin1 commented Aug 20, 2020

felixfontein commented Aug 20, 2020

felixfontein left a comment

Choose a reason for hiding this comment

heuels left a comment

Choose a reason for hiding this comment

felixfontein commented Aug 21, 2020