Allow network_cli type for platforms using persistent connection #120
Conversation
Fixes: ansible-collections#119 * For platforms using persistent allow network_cli connection type In ansible 2.6 `network_cli` connection was added as first class connection, however some of the community platform code was not updated to use `network_cli`. * Deprecate local connection type for platforms that use persistent connection framework and have cliconf and terminal plugins implemented.
plugins/action/aireos.py
Outdated
| task_vars['ansible_socket'] = socket_path | ||
| msg = "connection local support for this module is deprecated use either" \ | ||
| " 'network_cli' or 'ansible.netcommon.network_cli' connection" | ||
| deprecate(msg, version='4.0.0', collection_name='community.network') |
There was a problem hiding this comment.
I don't think this method has any effect (it stores its result in global variables which aren't read). Better use display.deprecated().
felixfontein
added
the
check-before-release
|
@felixfontein Thanks for reviewing the PR. It will be great if we can get some reviews from the individual platform owners. For platform using persistent connection framework, we would like to get away from using connection=local and promote the use of connection=network_cli. |
felixfontein
removed
the
check-before-release
|
@ganeshrn feel free to add it to the agenda. Not sure whether it will get a lot of additional eyes, I'm not sure anyone interested in this collection attends that meeting (except @gundalow and me). It might make more sense to CC all relevant people in this PR. (Once we have ansibullbot here it should have already done it, but we don't have the bot yet...) |
|
CC @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @xuxiaowei0512 @yanzhangi @zengchen1024 @zhongjun2 @istaicu @mihaibroc @amuraleedhar @paulquack |
|
The changes (for Lenovo CNOS and ENOS) look good for me. |
* Allow network_cli type for platforms using persistent connection Fixes: #119 * For platforms using persistent allow network_cli connection type In ansible 2.6 `network_cli` connection was added as first class connection, however some of the community platform code was not updated to use `network_cli`. * Deprecate local connection type for platforms that use persistent connection framework and have cliconf and terminal plugins implemented. * add changelog * Fix review comments * minor updates * remove unwanted space * FIx more santiy issues * fix review comments (cherry picked from commit b5629d7)
… (#133) * Allow network_cli type for platforms using persistent connection Fixes: #119 * For platforms using persistent allow network_cli connection type In ansible 2.6 `network_cli` connection was added as first class connection, however some of the community platform code was not updated to use `network_cli`. * Deprecate local connection type for platforms that use persistent connection framework and have cliconf and terminal plugins implemented. * add changelog * Fix review comments * minor updates * remove unwanted space * FIx more santiy issues * fix review comments (cherry picked from commit b5629d7) Co-authored-by: Ganesh Nalawade <[email protected]>
|
@ganeshrn thanks for implementing this! |
SUMMARY
Fixes:
#119
In ansible 2.6
network_cliconnection was added as first classconnection, however some of the community platform code was not
updated to use
network_cli.connection framework and have cliconf and terminal plugins
implemented.
ISSUE TYPE
COMPONENT NAME
plugins/action/ce.py
plugins/action/cnos.py
plugins/action/enos.py
plugins/action/ironware.py
plugins/action/sros.py
plugins/module_utils/network/aireos/aireos.py
plugins/module_utils/network/aruba/aruba.py
plugins/module_utils/network/cloudengine/ce.py
plugins/module_utils/network/cnos/cnos.py
plugins/module_utils/network/enos/enos.py
plugins/module_utils/network/ironware/ironware.py
ADDITIONAL INFORMATION