dladm_vnic python3 fixes and tests #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix logic to match the `is_valid_{unicast_mac,vlan_id}` function names and don't allow VLAN 0.
* Add tests for this module.
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Oct 14, 2020
Co-authored-by: Felix Fontein <[email protected]>
|
@jbronn thanks for fixing this! |
patchback bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
* * Explicitly add types for all module arguments.
* Fix logic to match the `is_valid_{unicast_mac,vlan_id}` function names and don't allow VLAN 0.
* Add tests for this module.
* Add changelog fragment.
* Fix sanity tests.
* No longer need to ignore 'doc-missing-type'.
* Update changelog fragment.
Co-authored-by: Felix Fontein <[email protected]>
* The valid VID range is 1-4094, confirmed from the Illumos source code.
* Update changelog fragment.
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit cfe13ea)
felixfontein
pushed a commit
that referenced
this pull request
Oct 15, 2020
* * Explicitly add types for all module arguments.
* Fix logic to match the `is_valid_{unicast_mac,vlan_id}` function names and don't allow VLAN 0.
* Add tests for this module.
* Add changelog fragment.
* Fix sanity tests.
* No longer need to ignore 'doc-missing-type'.
* Update changelog fragment.
Co-authored-by: Felix Fontein <[email protected]>
* The valid VID range is 1-4094, confirmed from the Illumos source code.
* Update changelog fragment.
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit cfe13ea)
Co-authored-by: Justin Bronn <[email protected]>
|
@jbronn hi, would you like to have your GH login added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #131 and adds tests for
dladm_vnicmodule.ISSUE TYPE
COMPONENT NAME
dladm_vnicADDITIONAL INFORMATION
N/A.