ftd httpapi plugin: handle missing urllib3 imports #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
fix-imports
branch
from
0466e61 to
af6fc70
Compare
|
recheck |
dmsimard
approved these changes
Nov 14, 2020
patchback bot
pushed a commit
that referenced
this pull request
Nov 14, 2020
* ftd httpapi plugin: handle missing urllib3 imports (cherry picked from commit 172ba15)
|
@dmsimard for most repos it's pretty simple, right before opening the PR, go to https://github.com/ansible-collections/community.network/issues/?q= and look what the latest used number was, and add one. In the unlikely case someone created a PR or issue between you checking the number and creating your own PR, you'll have to force-push or add another commit, but in 99% of the time it'll work fine ;) |
|
@dmsimard thanks for reviewing and merging! |
felixfontein
added a commit
that referenced
this pull request
Nov 14, 2020
* ftd httpapi plugin: handle missing urllib3 imports (cherry picked from commit 172ba15) Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #147.
ISSUE TYPE
COMPONENT NAME
plugins/httpapi/ftd.py