Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stable-1 CI #226

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Conversation

dericcrago
Copy link
Contributor

SUMMARY

fix failing CI, see ansible-collections/overview#45 (comment) for more info

@felixfontein
Copy link
Collaborator

@dericcrago for some CI errors to go away, you also need to limit the ansible.netcommon version in the dependency install in CI (

retry ansible-galaxy -vvv collection install ansible.netcommon
).

(And then there are some more CI errors (mainly sanity errors) which are unrelated to this.)

@dericcrago dericcrago changed the title lock 'ansible.netcommon' dependency to '>=1.0.0,<2.0.0' fix stable-1 CI Mar 16, 2021
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dericcrago dericcrago merged commit 18f4d39 into ansible-collections:stable-1 Mar 16, 2021
@dericcrago
Copy link
Contributor Author

thanks for the reviews @felixfontein & @Andersson007 !

@dericcrago dericcrago deleted the stable-1_CI branch March 16, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants