Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fixes #228

Merged
merged 3 commits into from
Mar 24, 2021
Merged

CI fixes #228

merged 3 commits into from
Mar 24, 2021

Conversation

dericcrago
Copy link
Contributor

SUMMARY

CI fixes around ansible/ansible#73703.

  • switched to public common validation methods:
    • plugins/modules/network/cnos/cnos_static_route.py
    • plugins/modules/network/icx/icx_static_route.py
  • fixed / simplified regex matching:
    • tests/unit/plugins/modules/network/slxos/test_slxos_interface.py
    • tests/unit/plugins/modules/network/slxos/test_slxos_l2_interface.py
    • tests/unit/plugins/modules/network/slxos/test_slxos_l3_interface.py
    • tests/unit/plugins/modules/network/slxos/test_slxos_linkagg.py
    • tests/unit/plugins/modules/network/slxos/test_slxos_lldp.py
    • tests/unit/plugins/modules/network/slxos/test_slxos_vlan.py
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • plugins/modules/network/cnos/cnos_static_route.py
  • plugins/modules/network/icx/icx_static_route.py
  • tests/unit/plugins/modules/network/slxos/test_slxos_interface.py
  • tests/unit/plugins/modules/network/slxos/test_slxos_l2_interface.py
  • tests/unit/plugins/modules/network/slxos/test_slxos_l3_interface.py
  • tests/unit/plugins/modules/network/slxos/test_slxos_linkagg.py
  • tests/unit/plugins/modules/network/slxos/test_slxos_lldp.py
  • tests/unit/plugins/modules/network/slxos/test_slxos_vlan.py

felixfontein
felixfontein reviewed Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the modules require a changelog fragment (something like ansible-collections/community.general@24f8be8#diff-06b43f545ac93285b4482cf8334321a5397c0a584edd8e88981472d2e3cf91b5R2 maybe).

@dericcrago dericcrago merged commit 97c496f into ansible-collections:main Mar 24, 2021
@dericcrago
Copy link
Contributor Author

thanks for the review @felixfontein & @Andersson007

patchback bot pushed a commit that referenced this pull request Mar 24, 2021
@dericcrago
CI fixes (#228)
d83db42 
* switched to public common validation methods

* fixed / simplified regex matching

* added changelog fragment for {cnos,icx}_static_route modules fix

(cherry picked from commit 97c496f)
@patchback patchback bot mentioned this pull request Mar 24, 2021
Merged
dericcrago added a commit that referenced this pull request Mar 24, 2021
@patchback @dericcrago
CI fixes (#228) (#230)
c13e5e0 
* switched to public common validation methods

* fixed / simplified regex matching

* added changelog fragment for {cnos,icx}_static_route modules fix

(cherry picked from commit 97c496f)

Co-authored-by: Deric Crago <[email protected]>
@dericcrago dericcrago mentioned this pull request Mar 24, 2021
Merged
dericcrago added a commit that referenced this pull request Mar 24, 2021
@dericcrago
[PR #228/adjusted backport][stable-1] CI fixes (#231)
2f6b0c2 
* switched to public common validation methods

* fixed / simplified regex matching

* added changelog fragment for {cnos,icx}_static_route modules fix
@dericcrago dericcrago deleted the CI_fixes branch March 24, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dericcrago @felixfontein @Andersson007