routeros: Bug fix: Exception catching #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function get_capabilities was failing to catch connections exceptions, what make an ugly output
OUTPUT BEFORE CHANGES:
The full traceback is:
Traceback (most recent call last):
File "/root/.ansible/tmp/ansible-local-20843l7aphwz5/ansible-tmp-1588555470.4121525-264386939405924/AnsiballZ_routeros_comle>
_ansiballz_main()
File "/root/.ansible/tmp/ansible-local-20843l7aphwz5/ansible-tmp-1588555470.4121525-264386939405924/AnsiballZ_routeros_comallz_main
invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
File "/root/.ansible/tmp/ansible-local-20843l7aphwz5/ansible-tmp-1588555470.4121525-264386939405924/AnsiballZ_routeros_com_module
runpy.run_module(mod_name='ansible.modules.network.routeros.routeros_command', init_globals=None, run_name='__main__', a
File "/usr/lib64/python2.7/runpy.py", line 176, in run_module
fname, loader, pkg_name)
File "/usr/lib64/python2.7/runpy.py", line 82, in _run_module_code
mod_name, mod_fname, mod_loader, pkg_name)
File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/modules/network/routeros/r7, in <module>
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/modules/network/routeros/r7, in main
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/module_utils/network/routein run_commands
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/module_utils/network/routen get_connection
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/module_utils/network/routen get_capabilities
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/module_utils/connection.py
ansible.module_utils.connection.ConnectionError: Failed to authenticate: Authentication failed.
fatal: [MK]: FAILED! => changed=false
module_stderr: |-
Traceback (most recent call last):
File "/root/.ansible/tmp/ansible-local-20843l7aphwz5/ansible-tmp-1588555470.4121525-264386939405924/AnsiballZ_routerosmodule>
_ansiballz_main()
File "/root/.ansible/tmp/ansible-local-20843l7aphwz5/ansible-tmp-1588555470.4121525-264386939405924/AnsiballZ_routerosnsiballz_main
invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
File "/root/.ansible/tmp/ansible-local-20843l7aphwz5/ansible-tmp-1588555470.4121525-264386939405924/AnsiballZ_routerosvoke_module
runpy.run_module(mod_name='ansible.modules.network.routeros.routeros_command', init_globals=None, run_name='__main__
File "/usr/lib64/python2.7/runpy.py", line 176, in run_module
fname, loader, pkg_name)
File "/usr/lib64/python2.7/runpy.py", line 82, in _run_module_code
mod_name, mod_fname, mod_loader, pkg_name)
File "/usr/lib64/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/modules/network/routere 187, in <module>
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/modules/network/routere 157, in main
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/module_utils/network/r25, in run_commands
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/module_utils/network/r5, in get_connection
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/module_utils/network/r9, in get_capabilities
File "/tmp/ansible_routeros_command_payload_XbsRY1/ansible_routeros_command_payload.zip/ansible/module_utils/connectio
ansible.module_utils.connection.ConnectionError: Failed to authenticate: Authentication failed.
module_stdout: ''
msg: |-
MODULE FAILURE
See stdout/stderr for the exact error
rc: 1
OUTPUT AFTER CHANGES
fatal: [MK]: FAILED! => changed=false
msg: 'Failed to authenticate: Authentication failed.'
felixfontein
changed the title
|
This needs a changelog fragment ( CC @heuels |
felixfontein
reviewed
May 5, 2020
Andersson007
reviewed
May 5, 2020
|
@heuels if you have a bit of time, could you please review this PR? thanks :) |
|
@felixfontein, sorry for a slight delay :) |
|
@renatoalmeidaoliveira thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The function get_capabilities was failing to catch connections exceptions, what make an ugly output
ISSUE TYPE
COMPONENT NAME
routeros.py
ADDITIONAL INFORMATION
This error can be reproduced simply by providing an invalid username/password
OUTPUT BEFORE CHANGES:
OUTPUT AFTER CHANGES