routeros_facts: Allow multiple entries per iface #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, that makes sense, as I didn't adapt them to the new format. I would like to have a confirmation that changing the format is acceptable, however, before fixing the tests. The changelog could read something like |
|
@jplitza Yes, that sounds about right. Here is an example of a changelog entry from my recent PR: https://github.com/ansible/ansible/pull/68554/files#diff-87566feaded5be117df64f3c01233c4b |
|
@jplitza could you please add a changelog fragment? |
There can be multiple addresses per interface, as well as multiple neighbors. This changes the format of "ansible_net_neighbors" to list instead of dict, because the old format could not store multiple neighbors per interface. Also, this fixes a crash when the ipv6 module is not loaded, because the error "bad command name" was being parsed with interface=None
changelogs/fragments/6-routeros_facts-multiple-entries-per-iface.yml
Outdated
Show resolved
Hide resolved
changelogs/fragments/6-routeros_facts-multiple-entries-per-iface.yml
Outdated
Show resolved
Hide resolved
felixfontein
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There can be multiple addresses per interface, as well as multiple
neighbors.
This changes the format of "ansible_net_neighbors" to list instead of
dict, because the old format could not store multiple neighbors per
interface.
Also, this fixes a crash when the ipv6 module is not loaded, because the
error "bad command name" was being parsed with interface=None
ISSUE TYPE
COMPONENT NAME
routeros_facts
ADDITIONAL INFORMATION