Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move onyx from community.network to be mellanox.onyx collection #83

Merged
merged 3 commits into from
Jul 1, 2020

Conversation

samerd
Copy link
Contributor

@samerd samerd commented Jun 29, 2020

Signed-off-by: Samer Deeb [email protected]

SUMMARY

Remove all references to onyx from collection towards merging to a new collection and redirect to the new collection.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still missing multiple redirects in meta/runtime.yml, namely for the action plugin, the cliconf plugin, the module_utils, the docs fragment, and the terminal plugin. They also need to be redirected.

Also, most of these have not been changed in ansible/ansible#70213, Ansible still thinks that they are in this collection. That needs to be fixed too.

@felixfontein
Copy link
Collaborator

And finally, this PR needs a changelog fragment with removed_features.

meta/runtime.yml Show resolved Hide resolved
changelogs/fragments/83-remove-onyx.yml Outdated Show resolved Hide resolved
@gundalow
Copy link
Contributor

@samerd thanks for this PR.
When do you think you'll have the new collection build, even if it's just a 0.1.0 release?

We are wondering if we want to delete this content only after the new collection is live.

@samerd
Copy link
Contributor Author

samerd commented Jun 30, 2020

@gundalow : I am working on it now.
I can create a 0.1.0 release today or tomorrow

@samerd
Copy link
Contributor Author

samerd commented Jul 1, 2020

@gundalow mellanox.onyx -0.1.0 collection has been published

@gundalow
Copy link
Contributor

gundalow commented Jul 1, 2020

@gundalow mellanox.onyx -0.1.0 collection has been published

@samerd Thank you, ansible-community/ansible-build-data#11 means it will be included in the next ansible package

@gundalow gundalow merged commit 422635c into ansible-collections:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants