Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbix_template: Fix encode error occurs when using Python2 #297

Merged
merged 5 commits into from
Dec 27, 2020

Conversation

sky-joker
Copy link
Contributor

@sky-joker sky-joker commented Dec 26, 2020

SUMMARY

This PR is to fix encode error occurs when using Python2.
fixes: #233

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/297-zabbix_template_modules.yml
plugins/modules/zabbix_template.py
plugins/modules/zabbix_template_info.py

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #297 (3036118) into main (93cccb0) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   77.12%   77.17%   +0.05%     
==========================================
  Files          19       19              
  Lines        2675     2681       +6     
  Branches      685      687       +2     
==========================================
+ Hits         2063     2069       +6     
  Misses        409      409              
  Partials      203      203              
Impacted Files Coverage Δ
...ommunity/zabbix/plugins/modules/zabbix_template.py 76.56% <0.00%> (+0.27%) ⬆️
...ity/zabbix/plugins/modules/zabbix_template_info.py 80.95% <0.00%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6100751...3036118. Read the comment docs.

@sky-joker sky-joker changed the title [WIP] zabbix_template: Fix encode error occurs when using Python2 zabbix_template: Fix encode error occurs when using Python2 Dec 26, 2020
@sky-joker sky-joker requested a review from D3DeFi December 26, 2020 08:32
Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changelogs/fragments/297-zabbix_template_modules.yml Outdated Show resolved Hide resolved
@sky-joker
Copy link
Contributor Author

Thank you @D3DeFi for reviewing.
I fixed your pointed out.

@D3DeFi D3DeFi merged commit 21284a5 into ansible-collections:main Dec 27, 2020
@sky-joker sky-joker deleted the fix_issue233 branch December 27, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to export template ascii codec can't encode character
2 participants