Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zabbix_user module not working with Zabbix 5.4 #406

Merged

Conversation

href
Copy link
Contributor

@href href commented Jun 24, 2021

With 5.4, 'alias' has been renamed to 'username'. With this change it is
possible to use both parameters. The right one will be sent to the Zabbix
server transparently, depending on the server's version.

Resolves #398.

With 5.4, 'alias' has been renamed to 'username'. With this change it is
possible to use both parameters. The right one will be sent to the Zabbix
server transparently, depending on the server's version.

Resolves ansible-collections#398.
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #406 (09ae63d) into main (03421c8) will decrease coverage by 2.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   78.78%   76.75%   -2.03%     
==========================================
  Files          19       21       +2     
  Lines        2635     2960     +325     
  Branches      665      761      +96     
==========================================
+ Hits         2076     2272     +196     
- Misses        364      452      +88     
- Partials      195      236      +41     
Impacted Files Coverage Δ
...s/community/zabbix/plugins/modules/zabbix_proxy.py 50.00% <0.00%> (-40.17%) ⬇️
...ns/community/zabbix/plugins/modules/zabbix_user.py 88.94% <0.00%> (-0.29%) ⬇️
...ns/community/zabbix/plugins/modules/zabbix_host.py 83.33% <0.00%> (-0.18%) ⬇️
...community/zabbix/plugins/modules/zabbix_service.py 86.13% <0.00%> (ø)
...unity/zabbix/plugins/modules/zabbix_globalmacro.py 72.03% <0.00%> (ø)
...unity/zabbix/plugins/modules/zabbix_maintenance.py 68.21% <0.00%> (ø)
...ity/zabbix/plugins/modules/zabbix_template_info.py 80.95% <0.00%> (+0.95%) ⬆️
...ommunity/zabbix/plugins/modules/zabbix_template.py 77.99% <0.00%> (+1.89%) ⬆️
...s/community/zabbix/plugins/module_utils/helpers.py 75.00% <0.00%> (+2.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6061c49...09ae63d. Read the comment docs.

Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this patch. Pipeline for zabbix 5.4 is not enabled in our repo yet as it would fail, but running tests locally:

zabbix_version=5.4 docker-compose up -d
ansible-test integration test_zabbix_user

results in tests passing.

@D3DeFi D3DeFi merged commit 2cbcb1b into ansible-collections:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zabbix 5.4: user.alias has been renamed to user.username
2 participants