Review parameters used to connect to API #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the names were a little bit mixed... Define that all parameters to connect to API are prefixed by `zabbix_api_` followed by the API parameter name. For zabbix_proxy it's applied too, however aliases management is untouched.
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 76.81% 76.81%
=======================================
Files 22 22
Lines 3011 3011
Branches 773 773
=======================================
Hits 2313 2313
Misses 457 457
Partials 241 241 Continue to review full report at Codecov.
|
mention new parameters and suggest to deprecate the old ones.
klando
changed the title
|
I like it, also the "deprecated" messages! 👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The variables names were a little bit mixed...
Define that all parameters to connect to API are prefixed by
zabbix_api_followed by the API parameter name (except for http where it looks really useless).ISSUE TYPE
COMPONENT NAME
roles zabbix_agent, zabbix_proxy and zabbix_web
ADDITIONAL INFORMATION
The behavior should remain intact.