-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible-readme.rst: mention the ansible-build-data issue tracker #554
Conversation
The |
I like the formulation. |
Issues with the ``ansible`` package build process or serious bugs or | ||
vulnerabilities in a collection that are not addressed after opening an issue | ||
in the collection's issue tracker should be reported on | ||
`ansible-build-data's issue tracker <https://github.com/ansible-community/ansible-build-data/issues>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention the README here? I'm thinking of something like
For a more detailed overview, refer to the `ansible-build-data's README <https://github.com/ansible-community/ansible-build-data/blob/main/README.md>`_.
I'm not sure, so just commenting and not requesting a change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea, especially if we add ansible-community/ansible-build-data#322.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the suggestion, but I'm a bit hesitant to make this section longer. I'm open to adding that after ansible-community/ansible-build-data#322 is merged if others feel strongly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why edit anything in 7.x? it's eol and no changes will happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samccann this is a fixure for unit tests. If any older verison is rebuilt, the latest README.rst template has always been used. Simply ignore the filename. (The comment should have been for src/antsibull/data/ansible-readme.rst anyway, since that's the source of truth.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now https://github.com/ansible-community/ansible-build-data/pull/322has been merged :)
Issues with the ``ansible`` package build process or serious bugs or | ||
vulnerabilities in a collection that are not addressed after opening an issue | ||
in the collection's issue tracker should be reported on | ||
`ansible-build-data's issue tracker <https://github.com/ansible-community/ansible-build-data/issues>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why edit anything in 7.x? it's eol and no changes will happen.
Issues with the ``ansible`` package build process or serious bugs or | ||
vulnerabilities in a collection that are not addressed after opening an issue | ||
in the collection's issue tracker should be reported on | ||
`ansible-build-data's issue tracker <https://github.com/ansible-community/ansible-build-data/issues>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say at all what kind of issues we accept in ansible-build-data here? Can't we just refer to the README? Something like:
If you think the above issue trackers are the wrong place for your issue, there is also the
ansible-build-data's issue tracker <https://github.com/ansible-community/ansible-build-data/issues>
_. Please refer to theansible-build-data's README <https://github.com/ansible-community/ansible-build-data/blob/main/README.md>
for more details.
This lacks the information about "serious bugs or vulnerabilities in a collection that are not addressed after opening an issue in the collection's issue tracker", though... but I think we should mention the README somehow here. We have a lot more details about acceptable issues there, far more than we could or should go into here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you add a changelog fragment? |
@felixfontein There is a changelog fragment now :-) |
Thanks everyone! |
Ref: ansible-community/ansible-build-data#322 (comment)