Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert antsibull version into the build-ansible.sh script #563

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

felixfontein
Copy link
Collaborator

This is now possible thanks to #562!

@felixfontein felixfontein marked this pull request as draft November 22, 2023 19:10
@gotmax23
Copy link
Contributor

@felixfontein, I pushed a change to fix the package-files tests.

Copy link
Collaborator Author

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use a more explicit placeholder instead of a real version:

tests/test_data/package-files/7.5.0/build-ansible.sh Outdated Show resolved Hide resolved
tests/test_data/package-files/8.1.0/build-ansible.sh Outdated Show resolved Hide resolved
tests/verify_package_files.py Outdated Show resolved Hide resolved
@felixfontein felixfontein marked this pull request as ready for review November 22, 2023 20:44
Co-authored-by: Maxwell G <[email protected]>
@felixfontein felixfontein merged commit 15f22e1 into ansible-community:main Nov 24, 2023
8 checks passed
@felixfontein felixfontein deleted the version branch November 24, 2023 20:24
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants