Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename command lint-collection-meta to lint-build-data #622

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Rename command lint-collection-meta to lint-build-data #622

merged 1 commit into from
Sep 14, 2024

Conversation

felixfontein
Copy link
Collaborator

I think it's better to call the subcommand lint-build-data so we can add other checks for build data (for example, pieces file is sorted alphabetically, etc.).

@gotmax23 WDYT?

@felixfontein felixfontein mentioned this pull request Sep 12, 2024
Merged
samccann
samccann approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@felixfontein felixfontein marked this pull request as ready for review September 14, 2024 20:31
@felixfontein felixfontein merged commit 03b84f5 into ansible-community:main Sep 14, 2024
9 checks passed
@felixfontein felixfontein deleted the lint branch September 14, 2024 20:32
@felixfontein
Copy link
Collaborator Author

@samccann @gotmax23 thanks for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samccann samccann samccann approved these changes

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @gotmax23 @samccann