collection_upload test - fix sporadic failure #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collection Upload Tests
✓ user should not be able to upload new collection without permissions (12005ms)
✓ collection should be uploaded (13209ms)
✓ should not upload new collection version when user does not have permissions
1) should deprecate let user deprecate and undeprecate collections
3 passing (28s)
1 failing
1) Collection Upload Tests
should deprecate let user deprecate and undeprecate collections:
Error: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection.
Request failed with status code 403
https://github.com/ansible/ansible-hub-ui/runs/5854034056?check_suite_focus=true
the idea being the previous test doesn't wait long enough and gets a 403 in one of the requests .. wait for the list to appear first
No-Issue
|
well, tried 5 cypress runs and it only broke once and that was on the "use in controller" failure, not this one.. 🤞 (except the last run fails on issues caused by merging ansible/galaxy_ng#1057, ignoring here) |
ZitaNemeckova
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing (I hope)
https://github.com/ansible/ansible-hub-ui/runs/5854034056?check_suite_focus=true
the idea being the previous test doesn't wait long enough and gets a 403 in one of the requests .. wait for the list to appear first