Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItemActions: don't render 0 when an array is empty #1983

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Apr 26, 2022

(moving out of #1863)

When buttons or kebabItems are empty arrays, the length is 0 and a zero can end up displayed instead of the buttons.

@himdel himdel requested a review from ShaiahWren April 26, 2022 22:39
Copy link
Contributor

@ShaiahWren ShaiahWren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@himdel himdel merged commit 2773f1b into ansible:master Apr 27, 2022
@himdel himdel deleted the lia branch April 27, 2022 15:18
ShaiahWren pushed a commit to ShaiahWren/ansible-hub-ui that referenced this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants