Revert RBAC Roles #1205
Merged
Revert RBAC Roles #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d84dee6.
Revert "Create galaxy_ng specific Roles (ansible#1058)" This reverts commit 3fefab0. No-Issue
✅ Deploy Preview for galaxyng ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
awcrosby
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
lgtm. I recommend the squashed commit summarizes the reverts maybe like this:
Revert RBAC Roles (ansible#1057) and (ansible#1058)
* Revert "Remove django guardian (ansible#1057)", commit d84dee6
* Revert "Create galaxy_ng specific Roles (ansible#1058), commit 3fefab0
No-issue
|
Devshift job is successful: https://ci.int.devshift.net/job/ansible-galaxy_ng-pr-check/679/ |
rochacbruno
approved these changes
Apr 11, 2022
newswangerd
added a commit
that referenced
this pull request
Apr 13, 2022
This reverts commit 67dbd31.
newswangerd
added a commit
that referenced
this pull request
Apr 13, 2022
This reverts commit 67dbd31. No-Issue
newswangerd
added a commit
that referenced
this pull request
Apr 19, 2022
newswangerd
added a commit
that referenced
this pull request
May 16, 2022
newswangerd
added a commit
to newswangerd/galaxy_ng
that referenced
this pull request
Jun 2, 2022
This reverts commit 67dbd31. No-Issue
newswangerd
added a commit
to newswangerd/galaxy_ng
that referenced
this pull request
Jun 2, 2022
This reverts commit 67dbd31. No-Issue
newswangerd
added a commit
that referenced
this pull request
Jun 3, 2022
newswangerd
added a commit
to newswangerd/galaxy_ng
that referenced
this pull request
Jun 3, 2022
This reverts commit 67dbd31. No-Issue
newswangerd
added a commit
to newswangerd/galaxy_ng
that referenced
this pull request
Jun 3, 2022
This reverts commit 67dbd31. No-Issue
awcrosby
pushed a commit
to awcrosby/galaxy_ng
that referenced
this pull request
Jul 29, 2022
This reverts commit 67dbd31. No-Issue
awcrosby
pushed a commit
that referenced
this pull request
Aug 1, 2022
newswangerd
added a commit
that referenced
this pull request
Aug 10, 2022
newswangerd
added a commit
to newswangerd/galaxy_ng
that referenced
this pull request
Aug 11, 2022
This reverts commit 67dbd31. No-Issue
newswangerd
added a commit
that referenced
this pull request
Aug 15, 2022
* Revert "Revert RBAC Roles (#1205)" (#1212) * Fix CI on feature branches (#1271) * Fix groups on namespaces and container namespaces. (#1269) * Update pulp_container to 2.12, pulpcore to 3.19 (#1272) Issue: AAH-1526 * Migrate permissions from Groups to Roles (#1199) Issue: AAH-1128 * Upgrade to pulpcore 3.20 (#1279) Issue: AAH-1643 * Add python package name to AppConfig (#1314) No-Issue * Make roles and group/roles visible for users with group permission (#1316) No-Issue * Don't require 'view_group' permissions (#1367) Issue: AAH-1805 * Allow roles assignment to group with `change_group` permission (#1371) Issue: AAH-1766 * Remove deprecated media type from pulp_container. (#1380) Issue: AAH-1828 * Update pulp dependencies from commit hashes to pinned versions (#1381) No-Issue * Resolve guardian foreign key contraints in rbac migration (#1384) Issue: AAH-1765 * Fix bug preventing users with object permissions from adding groups to container namespaces. (#1387) Issue: AAH-1757 * Make my permissions work with proxy models. (#1389) No-Issue * Add RBAC roles tests (#1283) Issue: AAH-1609 * Resolve test issues after rebase to master (#1392) No-Issue * Remove guardian from LDAP on rbac-roles branch. (#1394) No-Issue * Mark current rbac roles, group test standalone_only (#1395) No-Issue * Add RBAC object tests (#1391) Issue: AAH-1850 * Add RBAC Roles CI workflow (#1398) No-Issue * Rename migrations to not override default branch (#1401) No-Issue * Add role check to app auth unit test (#1402) No-Issue * Clear out old django model permissions (#1404) No-Issue * Upgrade pulp container (#1399) No-Issue * Check expected state and behavior of group permissions (#1403) No-Issue Co-authored-by: David Newswanger <[email protected]> Signed-off-by: James Tanner <[email protected]> Co-authored-by: Brian McLaughlin <[email protected]> Co-authored-by: Jiří Jeřábek <[email protected]> Co-authored-by: Shaiah Emigh-Doyle <[email protected]> Co-authored-by: Andrew Crosby <[email protected]> Co-authored-by: jctanner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.