-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduled weekly dependency update for week 15 #1975
Conversation
This is kinda cool. Looking forward to seeing working builds coming soon TM :) |
@decentral1se I've checked it out locally with patched tox and there's at least one pytest plugin which doesn't yet support new pytest... We'll need to set up some filtering... Even if tox fix doesn't go through fast I've got a temporary workaround in my mind... |
As far as I can tell, it's only the pytest-verbose-parametrize plugin. Removing it results in some unfortunate test names, but tests at least begin to fail for new and interesting reasons at that point due to the use of deprecated pytest things. Instead of filtering, I think it would be worth removing the broken plugin and adapting to pytest>=4. It's only going to get more difficult to do so over time. |
@seandst it works with the version in master: |
I've pushed some updates to this branch for the purpose of testing in CI. Installing from Git is probably not the best idea ever though. |
FTR using pytest 4 causes deprecation failures: @pytest.fixture
def config_instance(molecule_file_fixture, molecule_data, request):
mdc = copy.deepcopy(molecule_data)
if hasattr(request, 'param'):
> util.merge_dicts(mdc, request.getfuncargvalue(request.param))
E _pytest.warning_types.RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue
~/src/github/ansible/molecule/test/unit/conftest.py:185: RemovedInPytest4Warning |
Ref #1984 |
Update pytest from 3.6.0 to 4.4.0.
Changelog
4.4.0
4.3.1
4.3.0
4.2.1
4.2.0
4.1.1
4.1.0
4.0.2
4.0.1
4.0.0
3.10.1
3.10.0
3.9.3
3.9.2
3.9.1
3.9.0
3.8.2
3.8.1
3.8.0
3.7.4
3.7.3
3.7.2
3.7.1
3.7.0
3.6.4