Revert ansible-changelog changes

[pabelanger]

This is clearly broken, and no longer checks to see if we are adding in
changelog fragments.

Given we don't have the time to properly debug this, we are going to
revert.

That said, the proper way to do this moving forward, is to create a new
job, which the logic that is needed. Then smoke test the heck out of it
on a specific repo.

Then, over time we can replace all projects with it. Sadly, this was
rushed into service before. Not laying fault, but think we need to do a
better job at catching all new features next time.

Signed-off-by: Paul Belanger [email protected]

[goneri]

An example: https://dashboard.zuul.ansible.com/t/ansible/status/change/130,468f1f7a0830dacfe1589ad46514a3245bd905bb

@quidame ^

[pabelanger]

@gundalow @quidame given you've been involved in this code. I know it is a friday too. I'd like to get jobs working again, then properly plan a new job to validate this code.

[quidame]

@pabelanger Yes I know there was an issue, it is reported here #804 and fixed there #805 (I hoped, but who cares ?). I don't understand why you prefer to go backward rather than forward, but nevertheless, the revert makes that the error message is still inconsistent with the actual check, and the check itself still reports false positives as reported here: #771.

Really, what is the purpose of this check ?? I guess it is not to break git smartitude, so why does it break it ?