Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scp.put() args order in the documentation snippet #659

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Fix scp.put() args order in the documentation snippet #659

wants to merge 2 commits into from

Conversation

kucharskim
Copy link

@kucharskim kucharskim commented Nov 14, 2024 •
edited by webknjaz
Loading

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 14, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/ansible-pylibssh-659
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Jakuje
Jakuje approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! Looks good.

@webknjaz webknjaz enabled auto-merge November 15, 2024 20:26
webknjaz
webknjaz approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webknjaz webknjaz changed the title Fix scp.put() usage in documentation sample Fix scp.put() args order in the documentation snippet Nov 15, 2024
auto-merge was automatically disabled November 19, 2024 07:47

Head branch was pushed to by a user without write access

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kucharskim
Copy link
Author

Sorry, I rebased to get rid of This branch is out-of-date with the base branch but I guess base branch moves to fast, so you probably have procedure to merge this properly.

@webknjaz
Copy link
Member

Rebasing is just a suggestion. It's not really mandatory for merging.

@webknjaz webknjaz enabled auto-merge November 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz

@Jakuje Jakuje Awaiting requested review from Jakuje

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kucharskim @webknjaz @Jakuje