Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename the date to ast_build_date in js #594

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: rename the date to ast_build_date in js #594

merged 2 commits into from
Dec 5, 2024

Conversation

Revathyvenugopal162
Copy link
Contributor

Before

image

After

image

The Date class or date module, if referenced in the API documentation, had all its docstrings replaced with the build date due to a conflict with the date variable in JavaScript, which caused only the date to render in the documentation. In the PR, the date variable was renamed to ast_build_date to resolve this issue.. reported by @jorgepiloto

@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner December 5, 2024 13:29
@github-actions github-actions bot added ui/ux Related with UI/UX design fix Pull requests related to resolving problems or errors labels Dec 5, 2024
@jorgepiloto jorgepiloto merged commit 5a2265b into main Dec 5, 2024
21 checks passed
@jorgepiloto jorgepiloto deleted the fix/date branch December 5, 2024 13:38
jorgepiloto pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests related to resolving problems or errors ui/ux Related with UI/UX design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants