Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: eddy current sweep Maxwell #5492

Merged
merged 5 commits into from
Nov 29, 2024
Merged

FIX: eddy current sweep Maxwell #5492

merged 5 commits into from
Nov 29, 2024

Conversation

gmalinve
Copy link
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (cbe9860) to head (9a4571a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5492       +/-   ##
===========================================
+ Coverage   17.20%   84.69%   +67.48%     
===========================================
  Files         143      143               
  Lines       60122    60118        -4     
===========================================
+ Hits        10346    50914    +40568     
+ Misses      49776     9204    -40572     

@gmalinve gmalinve marked this pull request as ready for review November 28, 2024 08:39
Copy link
Contributor

@jvela018 jvela018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmalinve , I added some minor comments. Let me know if they make any sense.

src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
tests/system/general/test_28_Maxwell3D.py Show resolved Hide resolved
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve requested a review from jvela018 November 29, 2024 08:34
Copy link
Contributor

@jvela018 jvela018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gmalinve gmalinve merged commit 1e04243 into main Nov 29, 2024
43 checks passed
@gmalinve gmalinve deleted the fix/eddy_current_sweep branch November 29, 2024 09:01
@gmalinve gmalinve linked an issue Nov 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Single Point" to add_eddy_current_sweep
3 participants