Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Choke designer extension #5493

Merged
merged 31 commits into from
Nov 29, 2024
Merged

FEAT: Choke designer extension #5493

merged 31 commits into from
Nov 29, 2024

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Nov 28, 2024

Description

Choke designer extension to model a choke in HFSS.
New extension style

Issue linked

#5439

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys Samuelopez-ansys linked an issue Nov 28, 2024 that may be closed by this pull request
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 98.63014% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (1e04243) to head (1bc62f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5493      +/-   ##
==========================================
+ Coverage   80.76%   84.74%   +3.97%     
==========================================
  Files         143      144       +1     
  Lines       60118    60191      +73     
==========================================
+ Hits        48557    51011    +2454     
+ Misses      11561     9180    -2381     

@Samuelopez-ansys Samuelopez-ansys marked this pull request as ready for review November 28, 2024 11:56
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 28, 2024 12:07
SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 29, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left minor comments

gmalinve
gmalinve previously approved these changes Nov 29, 2024
@Samuelopez-ansys Samuelopez-ansys merged commit 97985f6 into main Nov 29, 2024
42 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_5439 branch November 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choke extension
3 participants