Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Apply value to derivative variable #5499

Merged
merged 8 commits into from
Nov 29, 2024
Merged

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Nov 29, 2024

Description

Set tuning offset was not setting the value of the variable correctly

Issue linked

#5497

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (1e04243) to head (a22aef9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5499      +/-   ##
==========================================
+ Coverage   80.76%   84.70%   +3.94%     
==========================================
  Files         143      143              
  Lines       60118    60116       -2     
==========================================
+ Hits        48557    50924    +2367     
+ Misses      11561     9192    -2369     

SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 29, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left minor comments.
The two methods set_tuning_offset seem to be the exact same code. We should really think about refactoring a bit the code to avoid code duplicates.
Do we have an issue to track all those duplicates and see if we can't come up with new classes encapsulating all those duplicates ?

src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) November 29, 2024 07:58
@Samuelopez-ansys
Copy link
Member Author

I agree regarding the duplicities. In this case this method can be used only for SetupHFSS and SetupAuto, but not for the others, so we can add it to Setup class, and internally check if the Setups are of one of these 2 types. We can do It in another PR.

gmalinve
gmalinve previously approved these changes Nov 29, 2024
@Samuelopez-ansys Samuelopez-ansys merged commit 34f3198 into main Nov 29, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_5497 branch November 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants