-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Apply value to derivative variable #5499
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5499 +/- ##
==========================================
+ Coverage 80.76% 84.70% +3.94%
==========================================
Files 143 143
Lines 60118 60116 -2
==========================================
+ Hits 48557 50924 +2367
+ Misses 11561 9192 -2369 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left minor comments.
The two methods set_tuning_offset
seem to be the exact same code. We should really think about refactoring a bit the code to avoid code duplicates.
Do we have an issue to track all those duplicates and see if we can't come up with new classes encapsulating all those duplicates ?
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
I agree regarding the duplicities. In this case this method can be used only for SetupHFSS and SetupAuto, but not for the others, so we can add it to Setup class, and internally check if the Setups are of one of these 2 types. We can do It in another PR. |
Description
Set tuning offset was not setting the value of the variable correctly
Issue linked
#5497
Checklist