-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Readibility improvements #5544
Conversation
modeler of PostCommon class has been made internal
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the goal is to make modeler
internal, could we make _modeler
an attribute of the class instead of a property ? See my comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to modify a signature to use List
instead of list
. To make that work, you also need to add from typing import List
…s passes and set Theta and Phi to All in case they are not defined as variaton dictionary.
…s passes and set Theta and Phi to All in case they are not defined as variaton dictionary.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5544 +/- ##
==========================================
- Coverage 85.00% 85.00% -0.01%
==========================================
Files 151 151
Lines 60761 60761
==========================================
- Hits 51652 51649 -3
- Misses 9109 9112 +3 |
# Conflicts: # src/ansys/aedt/core/hfss3dlayout.py
Readibility improvements
Description
Fixed many docstrings errors!
modeler of PostCommon class has been made internal.
Issue linked
#5543
Checklist