-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.11 support in smoke tests #200
Conversation
576756a
to
cc093cf
Compare
Honestly, I don't like the idea of having red cross in the CI if that implies "enforcing" the merge. I'm going to wait a bit in PyMAPDL for the moment. |
It's not enforcing. For example, as soon as 2 people approve it, you will get the green box. It's just that some stages (which are categorized as experimental and are not required), fail in the workflow. I know it's not the cleanest way of having a workflow but it's the only easy way right now (apart from setting a different workflow that runs on a scheduled basis and tries out Python 3.11, e.g. every week)... Honestly, I kind of prefer that last idea hahaha |
I think I prefer it too..... another completely (non-mandatory) workflow for running python 3.11. I could do that in PyMAPDL. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me. Interesting use of include
and the matrix variable outside of the matrix scope.
@germa89 specific non-mandatory workflow implemented that runs every week and tries to build the package's wheelhouse and some minor smoke test. Maybe you can reuse it =) I think this way everything is more simple. Once this workflow starts working properly we can adapt the main workflow. |
As title says: including Python 3.11 in smoke tests and package build stages as an experimental stage (i.e. if it fails, it won't compromise the workflow)