Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 support in smoke tests #200

Merged
merged 15 commits into from
Oct 28, 2022

Conversation

RobPasMue
Copy link
Member

As title says: including Python 3.11 in smoke tests and package build stages as an experimental stage (i.e. if it fails, it won't compromise the workflow)

@RobPasMue RobPasMue self-assigned this Oct 25, 2022
@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Oct 25, 2022
@germa89
Copy link
Contributor

germa89 commented Oct 26, 2022

Honestly, I don't like the idea of having red cross in the CI if that implies "enforcing" the merge.

I'm going to wait a bit in PyMAPDL for the moment.

@RobPasMue
Copy link
Member Author

Honestly, I don't like the idea of having red cross in the CI if that implies "enforcing" the merge.

I'm going to wait a bit in PyMAPDL for the moment.

It's not enforcing. For example, as soon as 2 people approve it, you will get the green box. It's just that some stages (which are categorized as experimental and are not required), fail in the workflow. I know it's not the cleanest way of having a workflow but it's the only easy way right now (apart from setting a different workflow that runs on a scheduled basis and tries out Python 3.11, e.g. every week)...

Honestly, I kind of prefer that last idea hahaha

@germa89
Copy link
Contributor

germa89 commented Oct 27, 2022

Honestly, I kind of prefer that last idea hahaha

I think I prefer it too..... another completely (non-mandatory) workflow for running python 3.11. I could do that in PyMAPDL. Thank you!

Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me. Interesting use of include and the matrix variable outside of the matrix scope.

@RobPasMue
Copy link
Member Author

@germa89 specific non-mandatory workflow implemented that runs every week and tries to build the package's wheelhouse and some minor smoke test. Maybe you can reuse it =) I think this way everything is more simple. Once this workflow starts working properly we can adapt the main workflow.

@RobPasMue RobPasMue enabled auto-merge (squash) October 28, 2022 08:16
@RobPasMue RobPasMue requested a review from jorgepiloto October 28, 2022 09:04
@RobPasMue RobPasMue merged commit 971ae71 into main Oct 28, 2022
@RobPasMue RobPasMue deleted the feat/python-311-experimental-support branch October 28, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants