Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: check-licenses action #97

Merged
merged 6 commits into from
Nov 29, 2022
Merged

FEAT: check-licenses action #97

merged 6 commits into from
Nov 29, 2022

Conversation

GuillemBarroso
Copy link
Contributor

Adding check-licenses action.

Note that this action is still under testing and not merged to main branch in pyansys/actions.

@RobPasMue
Copy link
Member

LGTM @GuillemBarroso! My only complaint is that we should be able to accept a "target". Let me explain...

Right now, the command you are running is:

python -m pip install .

While this might be enough for most projects, for the pyansys/pyansys project it might not be enough since we have to check that the all target is compliant. That means running:

python -m pip install .[all]

I'd recommend to implement something similar to this logic:

If you have any doubts let me know. =)

@RobPasMue
Copy link
Member

I deleted the dependency reviewer action. I do think that this new action you set up is going to be more consistent than the previous one. Thanks @GuillemBarroso! I'll be merging once all checks succeed.

@RobPasMue RobPasMue enabled auto-merge (squash) November 29, 2022 08:02
@RobPasMue RobPasMue merged commit 9e3bc51 into main Nov 29, 2022
@RobPasMue RobPasMue deleted the feat/check-licenses branch November 29, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants