Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set obj_name for ADR items to always be a string #51

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

margalva
Copy link
Collaborator

Make sure that the name for ADR Items is always a string. If not, weird errors happen down the line

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #51 (bbe9454) into main (6ddfed9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   76.57%   76.68%   +0.10%     
==========================================
  Files          16       16              
  Lines        4829     4829              
  Branches     1022     1022              
==========================================
+ Hits         3698     3703       +5     
+ Misses        792      789       -3     
+ Partials      339      337       -2     
Files Changed Coverage Δ
src/ansys/dynamicreporting/core/adr_service.py 81.41% <100.00%> (+1.11%) ⬆️

... and 1 file with indirect coverage changes

@margalva margalva enabled auto-merge (squash) September 12, 2023 14:58
@margalva margalva merged commit 36cdbe9 into main Sep 12, 2023
21 checks passed
@margalva margalva deleted the fix/obj_name_type branch September 12, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants