-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vale warnings #2139
Fix vale warnings #2139
Conversation
Could it be that it wants us to write something like Edit: never mind, there are other false positives such as I think it is indeed best to just disable this check for now. |
The rule is in the google link mentioned in https://github.com/errata-ai/Google/blob/master/Google/Headings.yml. Funnily it shows the warning also for |
Following are seems to be correct.
|
@hpohekar That is a good point, not all of the warnings are false-positives, but there are way too many false-positives currently for us to keep it active. Even stuff like |
Yes, I agree. No idea. |
* Fix vale warnings * Accept some strings in doc * Temporarily skipping rpvar tests till the docker image is updated * Mark some tests to require codegen
* Fix vale warnings (#2139) * fix tensor type for displacement variable (#2145) * Fix set_state implementation for command argument instance. (#2147) * Update flobject.py (#2148) * SVAR Doc (#1635) * Test to catch Watchdog launch errors, and improved Watchdog behavior on Windows (#2144) * Cavitation Model Example And Example Warning Fix (#2102) * Add type annotations for some modules under services (#2108) * More robust Windows launch command for Watchdog (#2167) * Making h5py an optional dependency, not installed by default (#2171) * Expose settings root like in pyconsole. (#2149) * Remove timeout loop in FluentConnection (#2126) * Fix SVAR doc (#2172) --------- Co-authored-by: Mainak Kundu <[email protected]> Co-authored-by: Oleg Chernukhin <[email protected]> Co-authored-by: Prithwish Mukherjee <[email protected]> Co-authored-by: Harshal Pohekar <[email protected]> Co-authored-by: Aseem Jain <[email protected]> Co-authored-by: Prithwish Mukherjee <[email protected]> Co-authored-by: Adam Boutin <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
These warnings started appearing in multiple PRs - https://github.com/ansys/pyfluent/actions/runs/6505185628/job/17668355789?pr=2136#step:6:63
Some of these warnings seem false-positive. Why does
Import geometry
raise a warning, butDescribe geometry
does not?