Pass journal_file_names as command line arguments #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
commented
Nov 10, 2023
mkundu1
force-pushed
the
fix/journal-file-names
branch
from
fda02b9 to
c91d694
Compare
mkundu1
requested review from
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
hpohekar,
h-krishnan and
raph-luc
as code owners
mkundu1
force-pushed
the
fix/journal-file-names
branch
from
c91d694 to
376e6db
Compare
hpohekar
approved these changes
Nov 13, 2023
seanpearsonuk
approved these changes
Nov 13, 2023
prmukherj
approved these changes
Nov 13, 2023
mkundu1
force-pushed
the
fix/journal-file-names
branch
from
376e6db to
1716984
Compare
for more information, see https://pre-commit.ci
|
Seems to have been a random launch Fluent test failure, re-running tests |
raph-luc
reviewed
Nov 13, 2023
raph-luc
approved these changes
Nov 13, 2023
Co-authored-by: Raphael Luciano <[email protected]>
mkundu1
commented
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.