Plane surface creation. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajain-work
force-pushed
the
feat/plane_surface
branch
from
620acd3 to
2bcc225
Compare
|
@ajain-work Is there an issue with a description for what this feature is about? |
ajain-work
commented
Apr 8, 2022
| @@ -9,13 +9,82 @@ | |||
|
|
|||
|
|
|||
| class LocalObjectDataExtractor: | |||
| class _SurfaceAPI: | |||
There was a problem hiding this comment.
Class provides surface APIs i.e. create/delete surface.
ajain-work
commented
Apr 8, 2022
| return self.creation_method() == "yz-plane" | ||
| if name == "zx_plane": | ||
| return self.creation_method() == "zx-plane" | ||
| return True |
There was a problem hiding this comment.
Plane surface creation.
ajain-work
commented
Apr 8, 2022
| def surface_name_in_server(cls, local_surface_name): | ||
| return "_dummy_surface_for_pyfluent:" + local_surface_name | ||
|
|
||
| def _get_api_handle(self): |
There was a problem hiding this comment.
Switch from tui to settings API can be made here in future.
ajain-work
force-pushed
the
feat/plane_surface
branch
3 times, most recently
from
db1782a to
e7365c2
Compare
ajain-work
force-pushed
the
feat/plane_surface
branch
from
e7365c2 to
ea27f6c
Compare
dnwillia-work
approved these changes
Apr 8, 2022
dnwillia-work
approved these changes
Apr 8, 2022
|
I would really like to see unit/integration testing added concurrently with features. |
ajain-work
force-pushed
the
feat/plane_surface
branch
from
1464a7b to
ca285be
Compare
Merged
mkundu1
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added plane surface creation.
Also refactored code and moved surface api commands i.e. create/delete surface under class SurfaceApi.
Plane surface creation example