fix: Fix set_state issue with inactive children #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
seanpearsonuk,
prmukherj and
hpohekar
as code owners
hpohekar
approved these changes
Sep 23, 2024
prmukherj
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_unaliasmethod has been recently made an instance-method from classmethod to access the parent of an object (for supporting ".."). But, this has caused an issue while traversing the child hierarchy when some children are inactive during set_state. In this PR, I'm accessing children using base class'__getattribute__. The object level__getattribute__is still required to access aliased-child.I will patch the
_unaliasfunction on the Fluent side to fix this error in the current commonfiles' PyFluent.