Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support delayed settings_source assignment for built-in settings objects #3315

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Sep 25, 2024

The following 2 syntaxes are now supported:
1.

x = MyBuiltinSettings(settings_source=<solver_session>/<settings_root>, ...)
assert isinstance(x, <conventional settings class>)
x = MyBuiltinSettings(...)
assert isinstance(x, MyBuiltinSettings)
x.settings_source = <solver_session>/<settings_root>
assert isinstance(x, <conventional settings class>)
x.settings_source = <solver_session>/<settings_root>  # RuntimeError thrown from <conventional settings class>, re-assignment is not allowed. (Ideally, it should be AttributeError, need to fix from flobject.py.)

@mkundu1 mkundu1 changed the title feat: Support delayed session assignment for builtin objects feat: Support delayed session assignment for built-in objects Sep 25, 2024
@mkundu1 mkundu1 changed the title feat: Support delayed session assignment for built-in objects feat: Support delayed session assignment for built-in settings objects Sep 25, 2024
@mkundu1 mkundu1 changed the title feat: Support delayed session assignment for built-in settings objects feat: Support delayed settings_source assignment for built-in settings objects Sep 25, 2024
@mkundu1 mkundu1 merged commit fe5937d into main Sep 26, 2024
26 checks passed
@mkundu1 mkundu1 deleted the feat/session-reassign branch September 26, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants