Use launch_fluent to launch container while building gallery #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
force-pushed
the
testing/start_container
branch
from
21ae4a0 to
7e4fdc2
Compare
Closed
dnwillia-work
approved these changes
Apr 26, 2022
mkundu1
force-pushed
the
testing/start_container
branch
2 times, most recently
from
98cb219 to
5e922bb
Compare
seanpearsonuk
approved these changes
Apr 27, 2022
mkundu1
force-pushed
the
testing/start_container
branch
5 times, most recently
from
48b8a6f to
d5abdf6
Compare
mkundu1
commented
Apr 27, 2022
mkundu1
force-pushed
the
testing/start_container
branch
from
d5abdf6 to
41229fc
Compare
mkundu1
force-pushed
the
testing/start_container
branch
7 times, most recently
from
8322fb7 to
79c966e
Compare
mkundu1
force-pushed
the
testing/start_container
branch
from
79c966e to
e1e5846
Compare
mkundu1
force-pushed
the
testing/start_container
branch
5 times, most recently
from
5f11ca5 to
a755829
Compare
|
I have rebased this branch to try to resolve the checks. |
mkundu1
force-pushed
the
testing/start_container
branch
from
7579487 to
64a46b0
Compare
mkundu1
commented
May 12, 2022
| @@ -232,7 +232,7 @@ def launch_fluent( | |||
| else: | |||
| import ansys.fluent.core as pyfluent | |||
|
|
|||
| if pyfluent.BUILDING_GALLERY or pyfluent.RUNNING_PYTEST: | |||
| if os.getenv("PYFLUENT_LAUNCH_CONTAINER") == "1": | |||
There was a problem hiding this comment.
Using an env var is more suitable as we can set it from the CI script before starting pyfluent.
mkundu1
changed the title
mkundu1
force-pushed
the
testing/start_container
branch
3 times, most recently
from
7f471c1 to
d5412aa
Compare
mkundu1
force-pushed
the
testing/start_container
branch
from
d5412aa to
24d4150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.